Color names have additional numbers

Bug #1658320 reported by peregrine
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Low
peregrine

Bug Description

For example: https://youtu.be/xgy_vE8V7ro

OS: Ubuntu 16.04.1 LTS x86-64, Inkscape 0.92.0

Steps to obtain bug (It's always work for me):

1. Select auto palette
2. Fill some object with any color
3. Press Swatch button on Fill and Stroke
4. Rename color
5. Color will have additional number after name, which can be removed after second renaming

Tags: color ui
Revision history for this message
peregrine (andrej1741) wrote :

I fix it.

Changed in inkscape:
assignee: nobody → constantin (roco-constantin-b)
assignee: constantin (roco-constantin-b) → nobody
Revision history for this message
jazzynico (jazzynico) wrote :

Thanks for taking the time to file a report (and additional thanks for the patch)!

Bug reproduced on Xubuntu 16.04, Inkscape 0.91 and lp:inkscape rev. 15484.

Changed in inkscape:
importance: Undecided → Low
milestone: none → 0.93
status: New → Triaged
Revision history for this message
jazzynico (jazzynico) wrote :

Patch tested successfully.
Only a small concern when leaving the function without freeing the id in the rare case where the name is not valid. The attach v2 patch should be correct. Could you please confirm?
Thanks!

Changed in inkscape:
assignee: nobody → peregrine (andrej1741)
status: Triaged → In Progress
Revision history for this message
peregrine (andrej1741) wrote :

Yes. I forget to check other return operators, next time I'll be more careful.

Revision history for this message
jazzynico (jazzynico) wrote :

Fixed in lp:inkscape rev. 15494.
Thanks!

Changed in inkscape:
status: In Progress → Fix Committed
Revision history for this message
Patrick Storz (ede123) wrote :
Changed in inkscape:
milestone: 0.93 → 0.92.2
jazzynico (jazzynico)
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers