Broken icon in LPE 'Fill between many'

Bug #1654798 reported by Robert Funnell on 2017-01-07
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Low
su_v
0.92.x
Low
su_v

Bug Description

For 'Fill between many', in the Path Effects dialogue the paste icon is a page icon with a red X in it instead of being a clipboard icon. This is 0.92.0 r15299 under Windows; apparently it's also seen under Linux.

Related branches

su_v (suv-lp) wrote :

Reproduced with Inkscape 0.92 r15299 and lp:inkscape/0.92.x r15309 on OS X 10.7.5.

tags: added: livepatheffects ui
Changed in inkscape:
status: New → Confirmed
su_v (suv-lp) wrote :

Quick fix for the missing icon for lp:inkscape/0.92.x attached - please review.

<opinion>
The icons used in the Path Effects dialog might need some review: the use cases of the 'edit-paste' icon in 'Envelope Deformation' and 'Fill between many', 'Fill between strokes' seem slightly contradicting:
* In Envelope Deformation, the button with the 'edit-paste' icon pastes the path data from the clipboard into the patheffect definition as bend path.
* In the Fill between many/strokes path effects, the button with the 'edit-paste' icon links the path on the clipboard to the patheffect definition via id reference.
* In Envelope Deformation on the other hand, the 'edit-clone' icon is used for the 'Link path' action (link via id reference).
</opinion>

su_v (suv-lp) wrote :

Alternative patch for lp:inkscape/0.92.x to use 'edit-clone' in both 'Fill between many' and 'Fill between stroke', like in 'Envelope Deformation' (fixes the missing icon, too).

jazzynico (jazzynico) wrote :

Confirmed on Windows XP (32-bit), lp:inskcape/0.92.x rev. 15309.

Changed in inkscape:
importance: Undecided → Low
milestone: none → 0.93
status: Confirmed → Triaged
jazzynico (jazzynico) wrote :

Also reproduced on Xubuntu 16.04, lp:inkscape rev. 15482.

jazzynico (jazzynico) wrote :

Patch v2 (from comment #3) tested successfully on Windows XP (32-bit) with lp:inkscape/0.92 and on Xubuntu 16.04, lp:inkscape.

Changed in inkscape:
assignee: nobody → su_v (suv-lp)
status: Triaged → In Progress
tags: added: backport-proposed
Bryce Harrington (bryce) wrote :

jazzynico, looks good for inclusion in the 0.92.x branch.

jazzynico (jazzynico) wrote :

Fix committed in lp:inkscape/0.92.x rev. 15310 and lp:inkscape rev. 15404.

Changed in inkscape:
milestone: 0.93 → 0.92.1
status: In Progress → Fix Committed
Bryce Harrington (bryce) on 2017-01-13
Changed in inkscape:
milestone: 0.92.1 → 0.93
jazzynico (jazzynico) on 2017-01-21
tags: removed: backport-proposed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers