Node editor does not redraw within group

Bug #165457 reported by Buliabyak-users
4
Affects Status Importance Assigned to Milestone
Inkscape
Invalid
Medium
Jon A. Cruz

Bug Description

- draw two shapes

- group them

- select one by ctrl-click

- f2

- open another view

- in the other view, drag the group

Result: the nodes in the node editor are not redrawn.
This is because the object's repr has not changed, only
its parent <g> received a new transform= attribute.
Fixing this will require either propagating transforms
into groups immediately, or listening to parent's repr
(in addition to the selected object's repr) in node
editor. Not sure which approach is better.

Revision history for this message
Buliabyak-users (buliabyak-users) wrote :

I think the transform writer for a group must write the
transform to all its children, instead of simply adding a
transform= attribute to the group.

Revision history for this message
Mental-users (mental-users) wrote :

Listening to the parent SPItems is much more efficient. The work
required for that grows linearly rather than exponentially with
nesting depth (also, listeners are cheaper than propagating
transforms in the first place).

Revision history for this message
Mental-users (mental-users) wrote :

You know, I would have expected the node editor attaching to
the group's "modified" signal and listening for
PARENT_MODIFIED (as well as plain MODIFIED) should be
sufficient.

Revision history for this message
Kees Cook (kees) wrote :

This causes a segfault now when the app is Quit.

Revision history for this message
Kees Cook (kees) wrote :

CVS no longer crashes on Quit for me.

Revision history for this message
Jflemaire (jflemaire) wrote :

Works great for me with current CVS. This bug should be closed.

Revision history for this message
Buliabyak-users (buliabyak-users) wrote :

No, it's not fixed. Nodes remain unmoved when the group is
moved in another window (view > duplicate window).

Revision history for this message
Jflemaire (jflemaire) wrote :

Well, in that case I don't understand what the issue is, because the
nodes move here. If I select the group in window #2, the nodes on
the control- selected shape in window #1 follow the shape
wherever it goes in window #2. We must put different meanings to
the word "move", then :-)

Revision history for this message
Buliabyak-users (buliabyak-users) wrote :

By move I mean grab and drag by selector tool. By nodes I
mean the square handles in path nodes that are only visible
in the node tool. The bug is the fact that even though the
path itself moves, these nodes stay unmoved and thus become
disconnected from their path.

Revision history for this message
Bug Importer (bug-importer) wrote :

OK, I got it now. The two windows I had were maximised and so I
was Alt-Tabbing from one to the other and couldn't notice any
problem since the behaviour manifests itself while moving in real
time! With the two windows side by side there is definitely a lag.

Sorry for wasting anyone's time.

Revision history for this message
Kees Cook (kees) wrote :

The symptoms I saw last time I looked at this bug seem to be
fixed for me too.

Bulia: is the non-realtime issue a bug? The behavior before
was that the nodes _stayed_ disconnected even after you
released the mouse button. Now the nodes snap back to the
correct position after the move finishes. This is a huge
improvement, IMHO.

Revision history for this message
Buliabyak-users (buliabyak-users) wrote :

I may be stupid but for me they do NOT jump to place when I
release mouse. I need to click the path in the window where
they are misplaced, or do something else in that window.
Simply releasing mouse in the other window leaves them in
wrong place.

Revision history for this message
Jflemaire (jflemaire) wrote :

This is definitely not the case here. See below for a link to an
archive containing three snapshots of the operation:

- before the move
- during the move
- and just after I release the mouse. You can see that the second
window still has focus.

http://users.skynet.be/jflemaire/fichiers/node_editor.tar.bz2

Revision history for this message
Peter Lewerin (vermeil-deactivatedaccount) wrote :

Win XP, 0.45.1: this bug is still there.

Changed in inkscape:
status: New → Confirmed
Revision history for this message
Cerno (jan-biel) wrote :

Win XP, 0.46: the bug is still there

Revision history for this message
Krzysztof Kosinski (tweenk) wrote :

IMO opening a second view of the same editable document is a misfeature.

ScislaC (scislac)
Changed in inkscape:
assignee: nobody → Jon A. Cruz (jon-joncruz)
Revision history for this message
Jon A. Cruz (jon-joncruz) wrote :

Just caught comment #16. Having more than a single view is definitely not a misfeature. It's a critical aid to workflow for just about any serious artist, drafter, designer, etc. Most any drawing, illustration, CAD, etc. software support it.

Revision history for this message
su_v (suv-lp) wrote :

Still present with 0.48+devel r12978 (OS X 10.7.5).

tags: added: node-editing
Revision history for this message
Krzysztof Kosinski (tweenk) wrote :

Easier repro steps which do not require opening another view:

1. Draw two shapes
2. Group
3. Move the group
4. Select one of the shapes in the node editor
5. Press Ctrl+Z

The outline is no longer aligned with the shapes.

Revision history for this message
Beluga (buovjaga) wrote :

Still repro.

Win 7 64-bit
Inkscape 0.91 r13725

Revision history for this message
mray (mrayyyy) wrote :

Hi - thanks for reporting this bug, I've manually migrated it to Inkscape's new
bug tracker on GitLab, and closed it here.

Please feel free to file new bugs about the issues you're seeing at
http://inkscape.org/report.

Moved to: https://gitlab.com/inkscape/inbox/issues/321
Closed by: https://gitlab.com/mray

tags: added: bug-migration
Changed in inkscape:
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.