Comment 6 for bug 1652100

Revision history for this message
Christopher M. Rogers (cajhne) wrote : Re: [Bug 1652100] Re: inkscape 20sec on unselect with node tool a long nodes path

Oh my god, thank you! Much much better! with 14,347 nodes it now only
takes 4.5 seconds to come out of node editing mode. That's quite an
improvement!

Thanks everyone for taking a look at this.
-C

On Mon, Mar 12, 2018 at 6:43 PM, Eduard Braun <email address hidden> wrote:
> Mc and I figured out why the commit mentioned in #3 regressed
> performance.
>
> I just committed a fix in
> https://gitlab.com/inkscape/inkscape/commit/8052d8eadcfa0201ee0ec7a1230bbf91c470da79
> which should restore previous performance.
>
> As this shows the data structure used here is not ideal some further
> optimizations in this code might be possible in future.
>
> ** Changed in: inkscape
> Status: Confirmed => Fix Committed
>
> ** Changed in: inkscape
> Assignee: (unassigned) => Eduard Braun (eduard-braun2)
>
> ** Changed in: inkscape
> Milestone: None => 0.93
>
> ** Tags added: backport-proposed
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1652100
>
> Title:
> inkscape 20sec on unselect with node tool a long nodes path
>
> Status in Inkscape:
> Fix Committed
>
> Bug description:
> Hi inkscape frezze on node tool unselect, select is about 1/2 sec in
> my machine, unselect moe than twenty. Hapends in trunk r.15348 and in
> 0.92.x. r.15276
>
> Original reported by CR with the link to the test file. I try today to
> fix and no look, seems deleting __mmap std::map<ShapeRecord,
> boost::shared_ptr<PathManipulator> > is too slow in this case. I try
> to fix but no lucky :(.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/inkscape/+bug/1652100/+subscriptions