Strings untranslatable due to word puzzles

Bug #1651334 reported by Yuri Chornoivan on 2016-12-20
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Low
jazzynico
0.92.x
Low
jazzynico

Bug Description

Some relatively new strings in 0.92.x branch are actually untranslatable due
to such called "string puzzles":

http://bazaar.launchpad.net/~inkscape.dev/inkscape/0.92.x/view/head:/share/extensions/draw_from_triangle.py#L179

inkex.errormsg(_("Side Length 'a' (" + unit + "): " + str( params[0][0] ) ))
inkex.errormsg(_("Side Length 'b' (" + unit + "): " + str( params[0][1] ) ))
inkex.errormsg(_("Side Length 'c' (" + unit + "): " + str( params[0][2] ) ))

http://bazaar.launchpad.net/~inkscape.dev/inkscape/0.92.x/view/head:/share/extensions/draw_from_triangle.py#L186

inkex.errormsg(_("Area ("+ unit + "^2): " + str( params[4][0] ) ))

extracts as

Side Length 'a' (
Side Length 'b' (
Side Length 'c' (
Area (

That is not what expected.

It was proposed to fix it like this:

inkex.errormsg(_("Side Length 'a'") + " (" + unit + "): " + str( params[0][0] ) )

But it is not a good way because of some languages (French) punctuation rules. In French, there should be a space before ":" ("Longueur du côté «a» (cm) :").

su_v (suv-lp) on 2016-12-20
tags: added: extensions-plugins i18n
jazzynico (jazzynico) on 2016-12-21
Changed in inkscape:
importance: Undecided → Low
status: New → Triaged
jazzynico (jazzynico) on 2016-12-23
Changed in inkscape:
assignee: nobody → jazzynico (jazzynico)
status: Triaged → In Progress
jazzynico (jazzynico) wrote :

I'd rather see something like:
inkex.errormsg(_("Side Length 'a' ({0}): {1}".format(unit, str(params[0][0])) ))

Full patch attached.

jazzynico (jazzynico) wrote :

Targetting 0.93.
Don't hesitate to tell me if it should be backported to 0.92 (I don't want to annoy translators with another tiny string update).

Changed in inkscape:
milestone: none → 0.93
jazzynico (jazzynico) wrote :

Difficult to test for now. All the Inkscape versions installed on my Xubuntu 16.04 computer don't translate the extension correctly (0.91, 0.92 and trunk). Investigations in progress.

jazzynico (jazzynico) wrote :

My fault. Working patch attached.

jazzynico (jazzynico) on 2017-01-09
tags: added: backport-proposed
jazzynico (jazzynico) wrote :

Backport accepted (IRC).

jazzynico (jazzynico) wrote :

Fixed in lp:inkscape/0.92.x rev. 15313 and lp:inkscape rev. 15405.

Changed in inkscape:
milestone: 0.93 → 0.92.1
status: In Progress → Fix Committed
Bryce Harrington (bryce) on 2017-01-13
Changed in inkscape:
milestone: 0.92.1 → 0.93
jazzynico (jazzynico) on 2017-01-21
tags: removed: backport-proposed
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers