Pattern Along Path LPE using "Repeated, stretched" doesn't stretch a single pattern smaller.

Bug #1621213 reported by Tim Rawlinson on 2016-09-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Undecided
Jabiertxof

Bug Description

When using the Pattern Along Path LPE and the "Repeated, stretched" setting, if the skeleton path is shorter than the pattern, no pattern is displayed. It seems the code just floors the number of copies and so in this case zero copies are used.

I would expect that at least one copy is always included and stretched down if needed.

Jabiertxof (jabiertxof) wrote :

This patch fix it

Changed in inkscape:
assignee: nobody → Jabiertxof (jabiertxof)
su_v (suv-lp) on 2016-09-08
tags: added: livepatheffects
Tim Rawlinson (tim-r) wrote :

Does that patch not completely alter its current behaviour? Changing from always stretching up to always stretching down? Would not an nbCopies = std::max(1, nbCopies) or similar be more appropriate?

Or, if the behaviour is to be completely changed, I think using std::round would be the better choice so that the amount of stretching is minimised. With an included check for 0 of course.

Jabiertxof (jabiertxof) wrote :

Are you OK.
Here is a better patch with your good indications.
Cheers, Jabier.

Tim Rawlinson (tim-r) wrote :

Thanks, I think that one would work fine.
Tim

Jabiertxof (jabiertxof) wrote :

Commiter to tunk and backported to 0.92.x.
Thanks Tim!

Changed in inkscape:
status: New → Fix Committed
Jabiertxof (jabiertxof) wrote :

trunk:r15110
0.92.x:r15075

Tim Rawlinson (tim-r) wrote :

Thanks a lot - quite a quick response! Makes me feel that I should be committing fixes to bugs like this myself!

Tim

Jabiertxof (jabiertxof) wrote :

I hope yes!

Qantas94Heavy (qantas94heavy) wrote :

Fix released with Inkscape 0.92.1.

Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers