Appending text in Text and Font dialog crashes Inkscape trunk

[Tavmjong Bah]

In trunk (but not in 0.92.x) Inkscape crashes if one appends text using the Text tab of the Text and Font dialog. (r15085).

(gdb) bt
#0 0x00007ffff2be9a90 in __dynamic_cast () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#1 0x00007ffff6fabd46 in sp_te_set_repr_text_multiline (text=0x6f19c20, str=0x90cd220 "aaaaabb") at src/text-editing.cpp:946
#2 0x00007ffff6c67ea1 in Inkscape::UI::Dialog::TextEdit::updateObjectText (this=0x7943260, text=0x6f19c20) at src/ui/dialog/text-edit.cpp:457
#3 0x00007ffff6c68777 in Inkscape::UI::Dialog::TextEdit::onApply (this=0x7943260) at src/ui/dialog/text-edit.cpp:560

[Mc (mc...)]

reproduced with trunk

[Patrick Storz (ede123)]

Reproduced on Windows 10 x64 with Inkscape trunk r15614 (MSYS2 build).

[Patrick Storz (ede123)]

Note that this also renders our gtkspell implementation useless...

[Patrick Storz (ede123)]

Fixed in
http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/15632

Regression was introduced in
http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/15047
specifically
http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/14954.1.20

It seems the 'children' attribute of SPObject (a ChildrenList aka boost::intrusive::list) doesn't like to be modified while being iterated over in a range-based for loop...