The "_dpi" field/member-var in CairoRenderContext is not used.

Bug #1614620 reported by Shlomi Fish on 2016-08-18
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

The "_dpi" field/member-var in CairoRenderContext is not used. Why is it there? I'll soon attach a patch that removes it, and with it all tests pass in "ninja check" and inkscape seems to run fine. Someone on IRC was grepping the code for "dpi" and thought it was used so it is misleading.

su_v (suv-lp) on 2016-12-24
tags: added: code-design
Bryce Harrington (bryce) wrote :

You might look and see if it would also need to be removed from the config xml in cairo-ps-out.cpp, cairo-ps-out.cpp, and cairo-renderer-pdf-out.cpp?

Shlomi Fish (shlomif-gmail) wrote :

@bryce : you mentioned "cairo-ps-out.cpp" twice. Did you mean two different files?

jazzynico (jazzynico) on 2017-01-03
Changed in inkscape:
importance: Undecided → Low
milestone: none → 0.93
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers