New extension 'Deep Ungroup' includes hard-coded unit conversion based on 90dpi

Bug #1594113 reported by su_v
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Medium
jazzynico

Bug Description

The recently added extension 'Deep Ungroup' (r14926) includes the method '_get_dimension()' (copied from the original Synfig export extension, bundled with Inkscape since 0.91) which hard-codes unit conversion factors based on Inkscape's legacy internal resolution of 90dpi. Likely this should be converted into a more flexible method which retrieves current values somehow via inkex's Effect() class; or at least updated to defaulting to 96dpi.

The same code in synfig_prepare.py (referenced in the comments) was adjusted to the new internal resolution (while keeping the values hard-coded) in rev 13659:
https://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/13659#share/extensions/synfig_prepare.py

Please note: I did not investigate which use cases could be affected directly by the assumption of legacy 90dpi.

jazzynico (jazzynico)
Changed in inkscape:
assignee: nobody → jazzynico (jazzynico)
importance: Undecided → Medium
milestone: none → 0.92
status: New → Triaged
Revision history for this message
jazzynico (jazzynico) wrote :

Fixed revision 14998.
I've applied the same change that was used in the Synfig extension for now. A better fix should be investigated to 0.93.

Changed in inkscape:
milestone: 0.92 → none
status: Triaged → Fix Released
tags: added: units
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.