Filter editor: sections vertically stretched proportinally to dialog height instead of content (rev >= 14846)

Bug #1570605 reported by su_v on 2016-04-14
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Undecided
insaner

Bug Description

The vertical layout of the filter editor dialog changed with rev 14846 (for bug #1436180), and stretches the different sections proportionally to the dialog's overall height, instead of keeping the parameter settings in the bottom part tightly packed. This reduces the vertical space available to display the filter primitives list (which can get quite long depending on the complexity of the filter effect).

Noticed with Inkscape 0.91+devel r14848 (GTK2) on OS X 10.7.5.

Attached are screenshots with rev 14845 (before, left) and rev 14848 (after, right) of the filter editor dialog, resized to fill the maximal available height in the document's main dock. The width of the dialog is unchanged, as original used when launching the dialog for the first time in the current session. The filter primitive infobox is turned off in the preferences for the screenshots (see bug #1570598 wrt empty placeholder area).

su_v (suv-lp) wrote :
description: updated
insaner (insaner) wrote :

Try this patch out and let me know if this solves both this and https://bugs.launchpad.net/inkscape/+bug/1570598

Changed in inkscape:
assignee: nobody → insaner (insaner)
su_v (suv-lp) wrote :

Combined patch tested with Inkscape 0.91+devel r14850, GTK+/X11 2.24.29 on OS X 10.7.5:
The issue with larger filter editor window is confirmed fixed: the parameter settings at the bottom part are tightly packed again, leaving more vertical screen estate to the list of filter primitives.

Not tested with GTK3 beyond confirming that it still compiles (usage of the filter editor with experimental GTK3 builds has been troubled for quite a while, and I consider the current state - with or without patch - as utterly unusable. This dialog will need a major rework for GTK3 once 0.92 has been released, with regard to all its elements).

As discussed with insaner on irc, with GTK2 (current default) the filter primitive infobox mostly displays cut off or even with zero height (probably with Ubuntu's custom scrollbar overlay), and requires the user to drag several pane handles to make it fully accessible (the initial aka minimal height of the box is the sum of the GUI controls for scrollbars (stepper + handle + stepper). See attached screenshot for a few examples.
With GNOME's default Adwaita GTK2 theme, unfortunately the downscaled former images illustrating the filter primitive (now with a size closer to large icons) are cut off at the bottom initially (gives the impression of an incorrectly laid-out dialog).

insaner (insaner) wrote :

Pushed up to revision 14856.

Changed in inkscape:
status: New → Fix Committed
su_v (suv-lp) wrote :

Reported issue never affected a stable release (no milestone required).

Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers