[PATCH] Get inkscape to build against recent libsigc++ which requires -std=c++11

[Shlomi Fish]

The cmake build against recent libsigc++-2.0s which require the -std=c++11 flag was broken again by a recent commit. The attached patch fixes it.

[Mc (mc...)]

I don't think it's required : In DefineDependsandFlags:371->374 , pkg-config detects if there is a need for c++11,and basically makes the output of SIGC++_CFLAGS_OTHER either -std=c++11 or nothing, the equivalent of

$ pkg-config sigc++-2.0 --cflags-only-other
-std=c++11

then the flag is added to cmake_cxx_flags in line 378

Did you try a fresh build which failed because of the lack of c++11 ?

[Shlomi Fish (shlomif-gmail)]

This is the compressed log of the build. As can be seen, the -std=c++11 flag was not added anywhere, and the build with ninja -j1 fails. I'm on Mageia Linux x86-64 v6.

[Shlomi Fish (shlomif-gmail)]

And for the record , this is what pkg-config gives me:

shlomif[ink]:$build$ pkg-config sigc++-2.0 --cflags-only-other

shlomif[ink]:$build$ pkg-config sigc++-2.0 --cflags
-I/usr/include/sigc++-2.0 -I/usr/lib64/sigc++-2.0/include

[Alex Valavanis (valavanisalex)]

@Mc Actually, I think I looked into this before... last time I checked, the pkg-config C++11 flag was added as a downstream patch in Debian, but not in the upstream GNOME development libraries.

In any case, since we will have a hard requirement on C++11 from 0.93 onwards, I think it's OK to patch this now.

[Mc (mc...)]

pushed in 14844