Node tool: handle size of selected nodes too big and sticky (rev >= 14761)

Bug #1568644 reported by su_v on 2016-04-11
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Inkscape
Low
Antonio Ospite
0.92.x
Low
Antonio Ospite

Bug Description

The handles of nodes as displayed in the node tool context usually enlarge slightly when selected, and revert to the original handle size (according to the user's setting) once deselected.

After the refactoring in rev 14761 [1] (to fix UX regression for pen/pencil start and end node handles), the handles in the node tool context grow on selection by a too large amount, and do not revert to the original size on deselection of the node: the path has to be deselected as a whole, and re-selected again to display with the expected handle size.

Attached are screen recordings of two different recent builds:
- Inkscape 0.91+devel r14760 (ok)
- Inkscape 0.91+devel r14770 (not ok)

[1] Related commit:
https://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/14761

su_v (suv-lp) wrote :

Screen recording r14760 (ok)

su_v (suv-lp) wrote :

Screen recording r14770 (not ok)

Martin Owens (doctormo) on 2016-04-11
Changed in inkscape:
assignee: nobody → Martin Owens (doctormo)
status: New → Confirmed
su_v (suv-lp) wrote :

@JazzyNico - could you please target to milestone 0.92? This regression can quickly turn node-editing sessions of more complex paths into a rather cumbersome activity (the mix of handle sizes after having selected and de-selected nodes is confusing, visually, at least to me).

jazzynico (jazzynico) on 2016-06-18
Changed in inkscape:
milestone: none → 0.92
status: Confirmed → Triaged
jazzynico (jazzynico) on 2016-08-29
Changed in inkscape:
importance: Undecided → Low
jazzynico (jazzynico) wrote :

Any chance it could be fixed for 0.92.1?
If not, please retarget to 0.93. Thanks!

Changed in inkscape:
milestone: 0.92 → 0.92.1
jazzynico (jazzynico) on 2017-02-16
Changed in inkscape:
milestone: 0.92.1 → 0.93
Antonio Ospite (ospite) wrote :

I took a look and the problem is that the changes from[1] introduce a bug in ControlManagerImpl::setSelected(), see lines numbers 333 and 337 in https://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/14761/src/ui/control-manager.cpp

The problem is that the previos code was changin targetSize directly while the new code sets item->ctrlResize = 2 conditionally but then does not use this value for the actual size, but the fixed _resize value.

The attached patch fixes the issue.

If the patch is OK let me know if you are going to apply it with git-am or if you prefer a merge request on gitlab.

Ciao,
   Antonio

Mc (mc...) wrote :
Changed in inkscape:
assignee: Martin Owens (doctormo) → Antonio Ospite (ospite)
status: Triaged → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers