Cannot edit swatch - regression

[insaner]

A recent commit seems to have broken the ability to edit a swatch in any way.

Likely to have been https://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/changes/14747
for https://bugs.launchpad.net/inkscape/+bug/1462907
https://bugs.launchpad.net/inkscape/+bug/1249618

Reproduce by either selecting a pre-existing swatch from the swatch dialog or the Stroke&Fill dialog.

r14748
Linux fc17 32bit

[su_v (suv-lp)]

Reproduced with Inkscape 0.91+devel r14753 on OS X 10.7.5.

Based on tests with archived builds:
- not reproduced with rev <= 14745,
- reproduced with rev >= 14747;
the regression was introduced in rev 14747 (14746 was just a translation update):
Revision 14747: Fix bugs with the colour selector self-signaling on change.
https://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/14747/

Steps to reproduce:
1) launch current trunk (new prefs, default new doc)
2) draw a rect; keep it selected
3) open Fill and Stroke
4) convert fill color (blue) to custom swatch
5) edit swatch color by dragging one of the color controls (slider) in the bottom half of the Fill and Stroke dialog
--> fails to update the swatch color

Note that numeric input (e.g. new RGBA values) still works.

[insaner (insaner)]

Adding back the line

        signal_changed.emit();

 in src/ui/selected-color.cpp brings back the old behavior (can edit the swatch, but cannot edit Hue or Saturation if luminance is at 0 or 255).

[Martin Owens (doctormo)]

Please don't add the broken line back, I've assigned this bug to myself in order to claim responsibility.

[Martin Owens (doctormo)]

On a second reading, I think you meant that you tested adding the line back, not that you added the line back. My mistake!

[insaner (insaner)]

Yes, that's what I meant, sorry about the confusing grammar/formatting. Let me know if I can help in any way.. I was trying to see if I could trace the source of the problem before you took ownership, but no luck.

[insaner (insaner)]

If by any chance in solving this one you could tackle
 https://bugs.launchpad.net/inkscape/+bug/1085371
as well, that would be great too.

[Martin Owens (doctormo)]

I've fixed this issue in r14757. My testing of swatches shows that it's got quite a few problems already and I'm not quite sure what it's supposed to be doing, but in this case it was easy as the signals for updating were almost all empty. I've tied drag and release signals so you should get color changes now and also as an added bonus, they should update as you drag too.

[Jabiertxof (jabiertxof)]

Great!

[insaner (insaner)]

Fix confirmed! Thank you!

[su_v (suv-lp)]

Proposing to reopen (not fixed):
1) while r14757 fixed the color sliders, it broke the RGBA entry (does not update the swatch color anymore) - this worked before (see also comment #1).
2) the spinbuttons to the right of the sliders are still broken (changes there are not applied to the swatch color).

Regression (RGBA entry) confirmed with archived builds (ok with r14756, not ok with r14758), both broken aspects (RGBA, spinbuttons) still present with latest trunk r14904.

[jazzynico (jazzynico)]

Issues from comment #10 confirmed on Windows XP, Inkscape trunk rev. 14909.

[Nathan Lee (nathan.lee)]

Closing as part of bug migration, issue is still being tracked in https://gitlab.com/inkscape/inkscape/-/issues/188