buildtool exclude/include issues
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Inkscape |
Fix Released
|
Wishlist
|
Patrick Storz |
Bug Description
The buildtool for building Inkscape on Windows has functionality to <include> and <exclude> specific files when compiling/
It seems however that there are some issues when parsing the regular expressions used for this functionality.
For example it's impossible to exclude *.a and *.la files from a library folder that contains dots (".") in the filename (I hit this issue with \lib"\gdk-
Since it seems that the library for parsing regular expressions [1] is known to have problems and is unmaintained I suggest to replace it with an alternative that does not have such issues and is actively maintained.
Attached is a simple patch that uses SLRE (Super Light Regular Expression library, [2]) instead.
In my tests it worked flawlessly, handled regular expressions as expected and didn't choke on any of the patterns I've thrown at it, so I guess it would be a reasonable replacement.
[1] T-Rex, http://
[2] https:/
Related branches
Changed in inkscape: | |
status: | Fix Committed → Fix Released |
milestone: | none → 0.92 |
Nice suggestion!
Note that it's probably a temporary fix since the current goal regarding the build systems is to use cmake for all operating systems (and thus drop btool).