Commit rev 14639 breaks cmake build

Bug #1543298 reported by Vladimir Savic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
High
Unassigned

Bug Description

Updating trunk to revision 14639 (Sync 2Geom to commit 5ee51c1c4f2066faa3e2c82021fc92671ad44ba4) broke cmake based configuring and produced invalid make files.
Terminal output:
CMake Error at CMakeScripts/HelperMacros.cmake:32 (add_library):
  Cannot find source file:

    d2-sbasis.h

  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp
  .hxx .in .txx
Call Stack (most recent call first):
  src/2geom/CMakeLists.txt:127 (add_inkscape_lib)

CMake Error: Cannot determine link language for target "2geom_LIB".
CMake Error: CMake can not determine linker language for target: 2geom_LIB

Fix provided on IRC by su_v. Patch attached.

Tags: 2geom build cmake
Revision history for this message
Vladimir Savic (vladimir-firefly-savic) wrote :
su_v (suv-lp)
tags: added: 2geom build cmake
Changed in inkscape:
importance: Undecided → High
milestone: none → 0.92
status: New → Triaged
Revision history for this message
Mc (mc...) wrote :

I committed the fix in r14642 since it was a major inconvenience and prevented from building with CMake, I'm not sure if there is anything to sync back to lib2geom or if it was all there was to do.

Revision history for this message
su_v (suv-lp) wrote :

On 2016-02-09 02:30 (+0100), Mc wrote:
> I'm not sure if there is anything to sync back to lib2geom

AFAICT no need to:
https://git.launchpad.net/lib2geom/commit/?id=4ae1a79099b799651073b0111122b12fac0d5e19

Changed in inkscape:
milestone: 0.92 → none
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.