Referencing External Script Causes Crash

[Jerold Haas]

# repro information #

## platform & version information: ##

- Inkscape 0.91 r13725
- Windows 10 Pro x64

## repro steps: ##

1. open inkscape using new document it
    creates by default
2. open document properties (shift+ctrl+D)
    if it's not already open
3. scripting > external scripts
4. click on `+` button
5. *boom* - it crashes

I've tried running this from cmd.exe | command.exe
to see if any STDOUT | STDERR output occurred: nothing.

[jazzynico (jazzynico)]

Reproduced on Windows XP (32-bit), Inkscape 0.91 and trunk rev. 14630.

Inkscape crashes on various actions, all related to the scripting dialog: selecting a script file, resizing the dialog, reopening the dialog...

The GDB trace is not as clear as on other operating systems, but it seems that the crash is related to memory management.

------
(gdb) run
Starting program: d:\Dev\inkscape-14630-Cairo-1.14.6+patch/inkscape.exe
....
warning: Lowest section in C:\PROGRA~1\FICHIE~1\MICROS~1\OFFICE14\Cultures\OFFICE.ODF is .text at 10001000
warning: Lowest section in C:\PROGRA~1\MICROS~2\Office14\1036\GrooveIntlResource.dll is .text at 10001000
....
warning: Heap corruption detected at 09AB6000
warning: Heap corruption detected at 09ABA028

Program received signal SIGSEGV, Segmentation fault.
0x7c9292f9 in ntdll!RtlRealPredecessor () from C:\WINDOWS\system32\ntdll.dll
(gdb) bt
#0 0x7c9292f9 in ntdll!RtlRealPredecessor () from C:\WINDOWS\system32\ntdll.dll
#1 0x003f0000 in ?? ()
#2 0x00000005 in ?? ()
#3 0x7c928cb4 in ntdll!RtlRealPredecessor () from C:\WINDOWS\system32\ntdll.dll
#4 0x003f0000 in ?? ()
#5 0x09abb000 in ?? ()
#6 0x00227dc8 in ?? ()
#7 0x09abb000 in ?? ()
#8 0x003f0000 in ?? ()
#9 0x003f0178 in ?? ()
#10 0x00000803 in ?? ()
#11 0x7c929f08 in ntdll!RtlpUnWaitCriticalSection () from C:\WINDOWS\system32\ntdll.dll
#12 0x7c939ba8 in towlower () from C:\WINDOWS\system32\ntdll.dll
#13 0x7c97fb98 in ntdll!RtlpNtMakeTemporaryKey () from C:\WINDOWS\system32\ntdll.dll
#14 0x7c95b244 in ntdll!LdrFindEntryForAddress () from C:\WINDOWS\system32\ntdll.dll

[jazzynico (jazzynico)]

Not reproduced with 0.48.5 (same computer).

[jazzynico (jazzynico)]

And not reproduced when using Gtk dialogs (Edit>Preferences>Interface>Windows>Desktop integration) instead of the native Windows dialogs.

[jazzynico (jazzynico)]

Reproduced again on Windows XP (32-bit), Inkscape 0.91 (every 3 tries) and 0.92 (after 10 tries).
On 0.91, I also had a case where the label of the Metadata tab disappeared, and some others where the File type (bottom of the file selection dialog) was more or less scrambled.
Looks like some kind of memory management issue.

[Patrick Storz (ede123)]

Can't reproduce with Inkscape 0.92.1 r15371 (32/64 bit) on Windows 10 x64.

I added random JavaScript files. Are there more specific steps to reproduce the issue?

[Patrick Storz (ede123)]

OK, now it crashed (seems to work flawlessly at times but crash at others).