Autotools-based builds lost 'Fullscreen' feature (rev >= 14547)

Bug #1529521 reported by su_v on 2015-12-27
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Medium
Unassigned

Bug Description

Recent changes in trunk's configure.ac seem to have removed a still used check for supported GTK+ features, in this case for 'fullscreen'.

Latest trunk r14554 on OS X 10.7.5 with GTK+/X11 2.24.29 outputs these warnings on launch:

> Unable to find: FullScreen
>
> ** (inkscape:96375): WARNING **: Unknown verb name: FullScreen
> Unable to find: FullScreenFocus
>
> ** (inkscape:96375): WARNING **: Unknown verb name: FullScreenFocus
> Unable to find: FullScreen

The former menu command 'View > Fullscreen' is defunct (displays instead greyed-out 'Verb "FullScreen" Unknown' as menu label), and the related keyboard shortcuts ('F11', 'Shift+F11') no longer work.

Related define in 'src/verbs.cpp':
https://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/view/14554/src/verbs.cpp#L1953

Not reproduced with:
- cmake-based build (same revision)
- archived earlier autotools-based builds (e.g. rev 14542)

su_v (suv-lp) wrote :

Use cases of HAVE_GTK_WINDOW_FULLSCREEN (according to csearch):
src/inkview.cpp:#ifdef HAVE_GTK_WINDOW_FULLSCREEN
src/verbs.cpp:#ifdef HAVE_GTK_WINDOW_FULLSCREEN
src/verbs.cpp:#endif // HAVE_GTK_WINDOW_FULLSCREEN
src/verbs.cpp:#ifdef HAVE_GTK_WINDOW_FULLSCREEN
src/verbs.cpp:#endif // HAVE_GTK_WINDOW_FULLSCREEN
src/verbs.h://#include "require-config.h" /* HAVE_GTK_WINDOW_FULLSCREEN */
src/verbs.h:#ifdef HAVE_GTK_WINDOW_FULLSCREEN
src/verbs.h:#endif /* HAVE_GTK_WINDOW_FULLSCREEN */
src/widgets/desktop-widget.cpp:#ifdef HAVE_GTK_WINDOW_FULLSCREEN
src/widgets/desktop-widget.cpp:#endif /* HAVE_GTK_WINDOW_FULLSCREEN */

Alex Valavanis (valavanisalex) wrote :

Regression should be fixed in lp:inkscape r14555

Changed in inkscape:
milestone: 0.92 → none
status: New → Fix Released
su_v (suv-lp) wrote :

Thanks a lot for the quick fix!

summary: - Autotools-based builds lost 'Fullscreen' feature (cmake not (yet)
- affected) (rev >= 14547)
+ Autotools-based builds lost 'Fullscreen' feature (rev >= 14547)
su_v (suv-lp) on 2015-12-28
Changed in inkscape:
importance: Undecided → Medium
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers