suspected memory leakage in move to layer command

[Anonymous]

Observation:
marking a lot of entities (around 15.000), right click -> "move to layer" -> select layer results in becoming very low and in parallel in an ongoing increase of memory usage.
For example, with the attached file, memory usage starts at approx 400 Megabytes, and increases up to approx. 4.250 Megabytes if I try to move approx. 5400 of these elements with this method to another layer.....
(Just while doing this InksSape crashes and shut down...)

Version: InkScape 0.91 r13725 (64 bit) and OS Windows 7 prof, 8 GB RAM
Attached I provide a file with approx 15.000 lines on two layers...., where I was able to observe this behavior too.

Anyway, thanks to everybody for this excellent piece of Software!

[jazzynico (jazzynico)]

Confirmed on Windows XP, Inkscape trunk rev. 14527.
Inkscape eats all available memory and crashes.
Not sure it's exactly a memory leak, but at least we have a performance et memory consumption issue.

[Mc (mc...)]

The issue was the following :
For each one of the 10⁴ elements to delete from the layer 1 to put on layer 2, it had to delete its selection cue, and finding each of them, linearly within the 10⁴ (z-ordered) was taking O(10⁸) operations, ie forever(i think it would not have taken more than a few hours). Solved(takes 13s now) by deselecting the elements before deleting them from the origin layer (same as what is done in deletion code)

[Mc (mc...)]

(pushed in r14528)

[jazzynico (jazzynico)]

Thanks Mc!

I haven't checked your patch yet, but how hard would it be to backport it to the 0.91.x branch?

[Mc (mc...)]

Not hard at all, it should apply without any modification

[jazzynico (jazzynico)]

Well, ok, but I see the patch is spread in different revisions... Could you please confirm only rev. 14528 and 14530 are relevant (and NOT 14529)? Thanks!

[Mc (mc...)]

Only r14528. (the three-lines diff)

r14530 is related to r14520.

[Martin Owens (doctormo)]

This has already been backported. Tag removed.