CMake: properly detect pango, fontconfig instead of linking explicitly

Bug #1512379 reported by su_v on 2015-11-02
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Low
Mc

Bug Description

Add proper detection for pango [1], fontconfig with cmake-based builds.

Right now, pango (and fontconfig) libraries are linked explicitly:

if (WIN32)
 list(APPEND INKSCAPE_LIBS "-L$ENV{DEVLIBS_PATH}/lib") # FIXME
 list(APPEND INKSCAPE_LIBS "-lpangocairo-1.0.dll") # FIXME
 list(APPEND INKSCAPE_LIBS "-lpangoft2-1.0.dll") # FIXME
 list(APPEND INKSCAPE_LIBS "-lpangowin32-1.0.dll") # FIXME
 list(APPEND INKSCAPE_LIBS "-lgthread-2.0.dll") # FIXME
elseif(APPLE)
 (…)
 list(APPEND INKSCAPE_LIBS "-lpangocairo-1.0") # FIXME
 list(APPEND INKSCAPE_LIBS "-lpangoft2-1.0") # FIXME
 list(APPEND INKSCAPE_LIBS "-lfontconfig") # FIXME
 (…)
else()
 list(APPEND INKSCAPE_LIBS "-ldl") # FIXME
 list(APPEND INKSCAPE_LIBS "-lpangocairo-1.0") # FIXME
 list(APPEND INKSCAPE_LIBS "-lpangoft2-1.0") # FIXME
 list(APPEND INKSCAPE_LIBS "-lfontconfig") # FIXME
 list(APPEND INKSCAPE_LIBS "-lX11") # FIXME
endif()

https://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/view/14441/CMakeScripts/DefineDependsandFlags.cmake#L12

--
[1] and harfbuzz (see bug #1488159)

jazzynico (jazzynico) on 2015-11-03
Changed in inkscape:
importance: Undecided → Low
status: New → Triaged
Mc (mc...) wrote :

Fixed during the Hackfest (r14794)

Changed in inkscape:
assignee: nobody → Mc (mc...)
status: Triaged → Fix Committed
Bryce Harrington (bryce) on 2017-01-10
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers