Path effect icon (w suggestion)

Bug #1494134 reported by insaner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Wishlist
insaner

Bug Description

It's time "Path effect" got its own icon. Instead of reinventing the wheel, I just used the same icon as
"path-effect-parameter-next" in icons.svg
without the yellow triangle (and replaced the "path-effect-parameter-next" icon with a clone to this one).

I have attached a patch. Please let me know if there are any problems or objections to the choice of icon for this purpose.

Revision history for this message
insaner (insaner) wrote :
Revision history for this message
su_v (suv-lp) wrote :

Thanks for the patch - the diff for icons.svg seems rather large; I'll try whether I manage to create a smaller one.

tags: added: livepatheffects ui
Changed in inkscape:
importance: Undecided → Wishlist
status: New → Confirmed
Revision history for this message
su_v (suv-lp) wrote :

Smaller diff; proposed icon placed in the 'menu' section; icon name changed to 'dialog-path-effects'

Revision history for this message
su_v (suv-lp) wrote :

Updated patch (v3) includes new icon for symbolic icons as well.

Revision history for this message
insaner (insaner) wrote :

Patch from #5 tested working, no problems.

Revision history for this message
jazzynico (jazzynico) wrote :

Patch tested successfully on Windows XP (32bit) with Inkscape trunk rev. 14355.

Changed in inkscape:
assignee: nobody → insaner (insaner)
milestone: none → 0.92
status: Confirmed → In Progress
Revision history for this message
insaner (insaner) wrote :

Hi su_v,
is this ready to commit and close?

Revision history for this message
jazzynico (jazzynico) wrote :

@insaner - Unfortunately the patch no longer applies correctly (Hunk #4 fails in icons.svg). Could you please take a look?

Revision history for this message
Tavmjong Bah (tavmjong-free) wrote :

Please be careful in editing the icons.svg file or it can gain a lot of cruft. It's probably better to hand edit. I can do that.

Revision history for this message
insaner (insaner) wrote :

I was just looking at https://bugs.launchpad.net/inkscape/+bug/1113302 and I'm thinking I can do both, if you guys don't mind that.

Revision history for this message
su_v (suv-lp) wrote :

Attaching updated minimal diff if patch from comment 5 against 0.91+devel r14757 - @Tav, please review and commit if ok.

Revision history for this message
Tavmjong Bah (tavmjong-free) wrote :

Committed in revision 14758 after purging a few unneeded properties.

Revision history for this message
insaner (insaner) wrote :

Fix confirmed. Thanks all!

Changed in inkscape:
status: In Progress → Fix Committed
Bryce Harrington (bryce)
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.