BSpline path effect: 'Default weight' uses wrong units (rev >= 14337)

Bug #1492704 reported by su_v on 2015-09-06
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Medium
Jabiertxof

Bug Description

The units for the weight of the curvature of the effect was changed in rev 14337 from the range of [0-1] to percentages. This works ok except for the button to reset the effect to the default weight: it seems that the calculation of the length of the node handles for the default weight still uses the values based on [0-1] and creates miniscule node handles which are so short that they don't affect the overall curvature (almost cusp), but may cause the stroke of the path to be rendered incorrectly (most noticeable when using a wider stroke).

Steps to reproduce:
1) draw a bspline path (e.g. with the pen or pencil tool), keep it selected
2) increase the stroke width (e.g. to 4)
3) open 'Path > Path Effects'
4) click on 'Default weight'

Expected result:
No change - the initial effect is supposed to use the default weight.

Actual result:
The output looks almost the same as if the user had clicked on 'Make cusp', but the rendering of the path's stroke may appear corrupted (e.g. near the corners of the original path), depending on the geometry of the original path and the current zoom level.

Reproduced with Inkscape 0.91+devel rev >= 14337 on OS X 10.7.5.

Note:
The default weight can be restored by e.g. decreasing and increasing the weight value by a single step using the spinbox (labeled "Change weight %') below the button 'Default weight'.

su_v (suv-lp) on 2015-09-06
summary: - BSpline path effect: 'Default weight' using wrong units (rev >= 14337)
+ BSpline path effect: 'Default weight' uses wrong units (rev >= 14337)
Jabiertxof (jabiertxof) wrote :

Fix it tonight, Thanks for the report

Jabiertxof (jabiertxof) on 2015-09-08
Changed in inkscape:
status: New → Fix Released
su_v (suv-lp) wrote :

Fixed in r14347.

Changed in inkscape:
milestone: 0.92 → none
su_v (suv-lp) wrote :

@Jabiertxof - thanks for the fix!

There's a another minor issue I just noticed with the 'Default weight' button: if BSpline is applied the first time to a path with only straight line segments (e.g. a rectangle, or a star), you need to click 'Default weight' twice - the first time, the result is asymmetric (the extracted handles are wrong).

Do you want me to file a new report?

Jabiertxof (jabiertxof) wrote :

@~suv not necesary bug. I commit a fix in 5 minutes! See you!

Jabiertxof (jabiertxof) wrote :

Fixed!

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers