Crash on SVG import (rev >= 13417)

[JonHurst]

Attached SVG causes crash on import, although fine on open.

Terminal output is:

terminate called after throwing an instance of 'std::logic_error'
  what(): basic_string::_S_construct null not valid

Emergency save activated!
Emergency save completed. Inkscape will close now.
If you can reproduce this crash, please file a bug at www.inkscape.org
with a detailed description of the steps leading to the crash, so we can fix it.
Aborted (core dumped)

=====
$ inkscape --version
Inkscape 0.91 r13725 (Feb 19 2015)

$ lsb_release -a
LSB Version: core-2.0-ia32:core-2.0-noarch:core-3.0-ia32:core-3.0-noarch:core-3.1-ia32:core-3.1-noarch:core-3.2-ia32:core-3.2-noarch:core-4.0-ia32:core-4.0-noarch:core-4.1-ia32:core-4.1-noarch:security-4.0-ia32:security-4.0-noarch:security-4.1-ia32:security-4.1-noarch
Distributor ID: Ubuntu
Description: Ubuntu 15.04
Release: 15.04
Codename: vivid

[su_v (suv-lp)]

Please add information about OS/platform and Inkscape version to the bug description, thank you.

[su_v (suv-lp)]

On OS X 10.7.5:
- not reproduced with Inkscape 0.48.5 r10040
- reproduced with Inkscape 0.91 r13725 and 0.91+devel r14262

Based on tests with archived builds:
- not reproduced with 0.91+devel rev <= 13416,
- reproduced with 0.91+devel rev >= 13417;
the crash seems related to changes originally introduced in r13417:
* Revision 13417: Fix for bug #1318657 and bug #1298967
  https://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/13417

Full backtrace with Inkcape 0.91+devel r14260 (debug build) attached.

[su_v (suv-lp)]

AFAICT stripping the comments from the defs section prevents the crash.

Attaching reduced test created with Inkscape 0.91+devel r14262, and one comment in the defs section (added outside of inkscape in vim).

[JonHurst (jon-a-hursts)]

#2

$ inkscape --version
Inkscape 0.91 r13725 (Feb 19 2015)

$ lsb_release -a
LSB Version: core-2.0-ia32:core-2.0-noarch:core-3.0-ia32:core-3.0-noarch:core-3.1-ia32:core-3.1-noarch:core-3.2-ia32:core-3.2-noarch:core-4.0-ia32:core-4.0-noarch:core-4.1-ia32:core-4.1-noarch:security-4.0-ia32:security-4.0-noarch:security-4.1-ia32:security-4.1-noarch
Distributor ID: Ubuntu
Description: Ubuntu 15.04
Release: 15.04
Codename: vivid

[Mc (mc...)]

fix committed in 14270

[su_v (suv-lp)]

r14670 backported to lp:inkscape/0.91.x (tested ok with Inkscape 0.91 r13781 on OS X 10.7.5).

[su_v (suv-lp)]

Fix backported to 0.91.x in rev 13807.