Sort color profile lists
Bug #1457126 reported by
houz
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Inkscape |
Fix Released
|
Wishlist
|
houz |
Bug Description
The lists of color profiles (for example in the document properties) gets sorted by filename. Sorting by displayed name would be nicer. The attached patch does that and also gets rid of some duplicates.
To see the duplicates just add the same directory (that also contains color profiles) to XDG_DATA_DIRS twice.
Related branches
tags: | added: color ui |
Changed in inkscape: | |
importance: | Undecided → Wishlist |
Changed in inkscape: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
The patch doesn't compile correctly on Crunchbang Waldorf (Debian stable based distro), and make returns the following errors:
-----
CXX color-profile.o c++/4.7/ algorithm: 63:0,
from /usr/include/ glibmm- 2.4/glibmm/ containerhandle _shared. h:30,
from /usr/include/ glibmm- 2.4/glibmm/ arrayhandle. h:23,
from /usr/include/ glibmm- 2.4/glibmm. h:91,
from /usr/include/ gdkmm-2. 4/gdkmm/ color.h: 9,
from color-profile. cpp:10: c++/4.7/ bits/stl_ algo.h: In instantiation of ‘_RandomAccessI terator std::__ unguarded_ partition( _RandomAccessIt erator, _RandomAccessIt erator, const _Tp&, _Compare) [with _RandomAccessIt erator = __gnu_cxx: :__normal_ iterator< std::pair< Glib::ustring, Glib::ustring>*, std::vector< std::pair< Glib::ustring, Glib::ustring> > >; _Tp = std::pair< Glib::ustring, Glib::ustring>; _Compare = bool (*)(std: :pair<Glib: :ustring, Glib::ustring>&, std::pair< Glib::ustring, Glib::ustring>&)]’: c++/4.7/ bits/stl_ algo.h: 2321:78: required from ‘_RandomAccessI terator std::__ unguarded_ partition_ pivot(_ RandomAccessIte rator, _RandomAccessIt erator, _Compare) [with _RandomAccessIt erator = __gnu_cxx: :__normal_ iterator< std::pair< Glib::ustring, Glib::ustring>*, std::vector< std::pair< Glib::ustring, Glib::ustring> > >; _Compare = bool (*)(std: :pair<Glib: :ustring, Glib::ustring>&, std::pair< Glib::ustring, Glib::ustring>&)]’ c++/4.7/ bits/stl_ algo.h: 2362:62: required from ‘void std::__ introsort_ loop(_RandomAcc essIterator, _RandomAccessIt erator, _Size, _Compare) [with _RandomAccessIt erator = __gnu_cxx: :__normal_ iterator< std::pair< Glib::ustring, Glib::ustring>*, std::vector< std::pair< Glib::ustring, Glib::ustring> > >; _Size = long int; _Compare = bool (*)(std: :pair<Glib: :ustring, Glib::ustring>&, std::pair< Glib::ustring, Glib::ustring>&)]’ c++/4.7/ bits/stl_ algo.h: 5514:4: required from ‘void std::sort(_RAIter, _RAIter, _Compare) [with _RAIter = __gnu_cxx: :__normal_ iterator< std::pair< Glib::ustring, Glib::ustring>*, std::vector< std::pair< Glib::ustring, Glib::ustring> > >; _Compare = bool (*)(std: :pair<Glib: :ustring, Glib::ustring>&, std::pair< Glib::ustring, Glib::ustring>&)]’ cpp:879: 69: required from here c++/4.7/ bits/stl_ algo.h: 2289:4: error: invalid initialization of reference of type ‘std::pair< Glib::ustring, Glib::ustring>&’ from expression of type ‘const std::pair< Glib::ustring, Glib::ustring>’ c++/4.7/ bits/stl_ algo.h: 2292:4: error: invalid initialization of reference of type ‘std::pair< Glib::ustring, Glib::ustring>&’ from expression of type ‘const std::pair< Glib::ustring, Glib::ustring>’
In file included from /usr/include/
/usr/include/
/usr/include/
/usr/include/
/usr/include/
color-profile.
/usr/include/
/usr/include/
make: *** [color-profile.o] Erreur 1