ICC profile filename with [] causes a crash (rev >= 13107)

Bug #1457069 reported by houz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
High
jazzynico

Bug Description

When trying to add an ICC profile in the document properties that contains [] in the filename makes Inkscape crash.

(inkscape:19472): glibmm-ERROR **:
unhandled exception (type std::exception) in signal handler:
what: Malformed URI

Program received signal SIGTRAP, Trace/breakpoint trap.
0x00007fffef77fd00 in g_logv () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
(gdb) bt
#0 0x00007fffef77fd00 in g_logv () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#1 0x00007fffef77ff3f in g_log () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2 0x00007ffff550851f in Glib::exception_handlers_invoke() () from /usr/lib/x86_64-linux-gnu/libglibmm-2.4.so.1
#3 0x00007ffff550f997 in Glib::SignalProxyNormal::slot0_void_callback(_GObject*, void*) ()
   from /usr/lib/x86_64-linux-gnu/libglibmm-2.4.so.1
#4 0x00007fffefa4e2d5 in g_closure_invoke () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#5 0x00007fffefa60342 in ?? () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#6 0x00007fffefa68698 in g_signal_emit_valist () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#7 0x00007fffefa688ff in g_signal_emit () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#8 0x00007ffff69012b5 in ?? () from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0
#9 0x00007fffefa4e504 in ?? () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#10 0x00007fffefa67fa7 in g_signal_emit_valist () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#11 0x00007fffefa688ff in g_signal_emit () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#12 0x00007ffff69001a9 in ?? () from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0
#13 0x00007ffff69a6a3f in ?? () from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0
#14 0x00007fffefa4e2d5 in g_closure_invoke () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#15 0x00007fffefa5ff32 in ?? () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#16 0x00007fffefa681a5 in g_signal_emit_valist () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#17 0x00007fffefa688ff in g_signal_emit () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#18 0x00007ffff6abdd6c in ?? () from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0
#19 0x00007ffff69a5184 in gtk_propagate_event () from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0
#20 0x00007ffff69a561b in gtk_main_do_event () from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0
#21 0x00007ffff6618b5c in ?? () from /usr/lib/x86_64-linux-gnu/libgdk-x11-2.0.so.0
#22 0x00007fffef778c3d in g_main_context_dispatch () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#23 0x00007fffef778f20 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#24 0x00007fffef779242 in g_main_loop_run () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#25 0x00007ffff69a4597 in gtk_main () from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0
#26 0x0000000000472e1c in sp_main_gui (argc=1, argv=0x7fffffffe008) at ../../src/main.cpp:1075
#27 0x00007fffee651b45 in __libc_start_main (main=0x4584b0 <main(int, char**)>, argc=1, argv=0x7fffffffe008,
    init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffdff8) at libc-start.c:287
#28 0x000000000046f087 in _start ()
(gdb)

su_v (suv-lp)
tags: added: color crash
Revision history for this message
su_v (suv-lp) wrote :

Reproduced with Inkscape 0.91 r13725 and 0.91+devel r14163 on OS X 10.7.5

Based on tests with archived builds:
- not reproduced with Inkscape 0.48.5
- not reproduced with 0.91+devel rev 13104,
- reproduced with 0.91+devel rev >= 13107;
the crash seems related to the removal of 'src/dom' in revision 13107:
http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/13107

Related earlier report (fixed):
Bug #1297557 “trunk: crash if document with linked color profile uses spaces in file name (rev >= 13107)”

Changed in inkscape:
importance: Undecided → High
milestone: none → 0.92
status: New → Confirmed
summary: - ICC profile filename with [] causes a crash
+ ICC profile filename with [] causes a crash (rev >= 13107)
tags: added: regression
jazzynico (jazzynico)
Changed in inkscape:
status: Confirmed → In Progress
assignee: nobody → jazzynico (jazzynico)
Revision history for this message
jazzynico (jazzynico) wrote :

Patch tested on Windows XP (32 bit) and Xubuntu 14.04 (64 bit), Inkscape trunk rev. 14225.

Revision history for this message
su_v (suv-lp) wrote :

Patch tested successfully with 0.91+devel r14224 on OS X 10.7.5 (X11-backend).

jazzynico (jazzynico)
tags: added: backport-proposed
Revision history for this message
jazzynico (jazzynico) wrote :

Fixed in the trunk, rev. 14229.

Changed in inkscape:
status: In Progress → Fix Committed
Revision history for this message
su_v (suv-lp) wrote :

Fix backported to 0.91.x in rev 13803.

Changed in inkscape:
milestone: 0.92 → 0.91.1
tags: removed: backport-proposed
jazzynico (jazzynico)
Changed in inkscape:
milestone: 0.91.1 → 0.92
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.