going from swatch to flat color should start with previous swatch color

Bug #1450112 reported by insaner on 2015-04-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Wishlist
insaner

Bug Description

Sometimes I want to go from a swatch (non-gradient) color to a flat color, but doing so causes the flat color to start from black instead of from the previously selected swatch color. It would be great to start from the last swatch color, as that is a more intuitive (and useful) starting point for the flat color. Even if the swatch was a gradient, you could always start from the first (or last) stop of the gradient.

su_v (suv-lp) on 2015-04-29
tags: added: color
Changed in inkscape:
importance: Undecided → Wishlist
status: New → Confirmed
insaner (insaner) on 2015-05-01
Changed in inkscape:
assignee: nobody → insaner (insaner)
insaner (insaner) wrote :

hi all, please test this patch and let me know what success (or failure) you have with it.

Basic testing: create an object, give it a flat color, select "swatch" or "gradient" or "radial gradient" in the "Fill and Stroke" dock, then click on "flat color" again, and see if it retains the desired color.

Jabiertxof (jabiertxof) wrote :

Plesae fix this tree hulks.
patching file src/widgets/paint-selector.cpp
Hunk #1 succeeded at 35 (offset -4 lines).
Hunk #2 succeeded at 659 (offset -4 lines).
Hunk #3 succeeded at 708 (offset -4 lines).

Jabiertxof (jabiertxof) wrote :

UX: I coudent reproduce the bug.

Bryce Harrington (bryce) wrote :

Posted some review comments for the patch on the inkscape-devel list, mainly cosmetics. LGTM otherwise.

insaner (insaner) wrote :

Fix committed revision 14109.
Thanks guys

Changed in inkscape:
status: Confirmed → Fix Committed
su_v (suv-lp) on 2015-05-04
Changed in inkscape:
milestone: none → 0.92
Bryce Harrington (bryce) on 2017-01-10
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers