Undocked Document Properties dialog allows to change settings of all opened documents

[Patrick Storz]

The undocked Document Properties dialog is not exclusive to a single document but allows to change settings of all opened documents (depending on which window is focused).

This might be OK, but does not work correctly:
* Values in the UI are not updated with respect to the currently focused window.
* It's possible to open multiple Document Properties dialogs (which all work on all documents)

Exemplary steps to reproduce the issue(s):
1. Open one instance of Inkscape ("New document 1")
   - Open Document Properties dialog for "New document 1".
   - Set width to 100 mm.
   - Close Document Properties dialog.
2. Open a second document ("New document 2") via "File -> New document"
   - Open Document Properties dialog for "New document 2".
   - Set width to 200 mm.
3. Focus "New document 1" and and observe first potential issue:
   - The UI values in the Document Properties dialog from step 2
     do not change...
4. Go back to Document Properties dialog, change width to 333 mm
   and observe second potential issue:
   - The width of ("New document 1") changes although
     the Document Properties dialog was opened for "New document 2"
     and still shows the values for the second document.
5. Close Document Properties dialog.
6. Focus "New document 1" again,
   open Document Properties dialog and observe third issue:
   - The Document Properties dialog for "New document 1" still
     shows the old width of 100 mm (from step 1)
   - However it is actually set to 333 mm (the value from step 4).

If you don't close the Document Properties dialogs between steps you're even ending up with multiple Document Properties dialogs and every one of them can change every document but they can therefore show totally inconsistent values.

All of the above works for other settings in Document Properties dialog, too.

The tests were performed with Inkscape 0.91 on Windows 7.

[Patrick Storz (ede123)]

Possibly related: Bug #1284278

[su_v (suv-lp)]

AFAICT a duplicate of
- Bug #1284278 “Undocked Document Properties dialog broken”
  https://bugs.launchpad.net/inkscape/+bug/1284278
or at least sharing the same underlying issue.

[Luis (oxydenz)]

Ok, looking for bugs saming mine... I think this one describes best...
I don't think it's a duplicate of #1284278 or if it is, bugs as #1803917 #1006438 #1418301 #1577060 are derived from the same fact.

We have a heavy problem with tools and properties windows in floating mode...
Using floating windows, at the moment you open or create a second document, all "tool windows" opens ALSO for that second document... And then we are lost: Windows doesn't more correspond to their respective document, in fact you have no way to know which window is for what...

---------------------------------------------------------------------------------
May be I'm totally wrong, but it seems that code is hesitating between two ideas:
-Having one set of "tool windows" for ALL opened documents, so changes affects only the actual/active/last focused doc.

- Having a set of "tool windows" for EVERY opened document... But in that case, "tool windows" MUST switch their display according to the active document. If not, user is f*** up...
---------------------------------------------------------------------------------

Kind of Conflict between System Window Manager and Inkscape's one?
It seems to, because changing this option (Windows options, "Dialogs on top" also) I obtained something correct... look attached image... Then I have only one set of "tool windows" switching the focus normally according to the active document...

------------------------------
Debian Stretch up to date...
Linux ***** 4.9.0-9-amd64 #1 SMP Debian 4.9.168-1+deb9u2 (2019-05-13) x86_64 GNU/Linux

Inkscape 0.92.1 r15371

[Jonathan Hofinger (jhofinger)]

I can't replicate this on current master. The floating Document Properties dialog seems to be firmly connected to one window, opening a second window with File->New and clicking the opened Document Properties focuses the first window, and changing values there only affects the first window as well.

If you can replicate this behavior in master or a more recent version of Inkscape, feel free to open an issue with http://inkscape.org/report.

Closed by: https://gitlab.com/jhofinger

[Patrick Storz (ede123)]

Still happens - are you trying on Windows 10 as well? Maybe returning focus to the original windows is OS-specific (I can see the original window coming to foreground, but it does not properly regain focus, i.e. the "current document" that the document properties dialog modifies is still the one opened subsequently).

I'll migrate this bug manually and add the relevant info.

[Patrick Storz (ede123)]

Let's close as duplicate of https://gitlab.com/inkscape/inkscape/issues/107

[Luis (oxydenz)]

I don't work with windows, only on Debian stable...
I signaled this bug on Debian 9 and is still there in debian 10 for amd64..
Inkscape up to date of course...
Thanks !

On 7/1/20 10:29, Patrick Storz wrote:
> Still happens - are you trying on Windows 10 as well? Maybe returning
> focus to the original windows is OS-specific (I can see the original
> window coming to foreground, but it does not properly regain focus, i.e.
> the "current document" that the document properties dialog modifies is
> still the one opened subsequently).
>
> I'll migrate this bug manually and add the relevant info.
>