Improve poppler checks in configure.ac
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Inkscape |
Fix Released
|
Medium
|
Alex Valavanis | ||
Inkscape Devlibs |
Fix Released
|
Wishlist
|
jazzynico |
Bug Description
TL;DR: I'd like to bump our Poppler dependency to > 18.4 and tidy up a lot of code. I'll go ahead in the next couple of days, if no objections.
We currently have over 100 lines in configure.ac dedicated just to checking for libpoppler. This creates a maintenance burden, and results in fairly messy conditional builds.
The first problem is that we don't check for the libpoppler private headers (We shouldn't be using these, but that's a separate issue!). This means that the configure script will happily let the user build Inkscape even though failure is inevitable. Instead, the script should output an error message and exit.
Second, we have a lot of output #define variable. Some of these can probably go away:
* HAVE_POPPLER: Use libpoppler for direct PDF import
* HAVE_POPPLER_CAIRO: Use libpoppler-cairo for rendering PDF preview
* HAVE_POPPLER_GLIB: Use libpoppler-glib and Cairo-SVG for PDF import
* [DONE] POPPLER_
* POPPLER_
* [DONE] POPPLER_
* POPPLER_
* POPPLER_
* [DONE] POPPLER_
Our Tracking Dependencies page [1] shows that even the oldest of our supported build environments can cope without some of these (Devlibs = poppler-0.12.1, Debian Wheezy = poppler-0.18.4).
Can I suggest the following:
1. Add a check for the necessary Poppler private headers
2. Bump our dependency level to Poppler >= 0.8.3 [done: lp:inkscape r13917]
3. Get rid of the POPPLER_NEW_GFXFONT test [done: lp:inkscape r13917]
4. Upgrade Devlibs Poppler version to something >= 0.18.4 [done: lp:inkscape-devlibs r56, lp:inkscape r14566, lp:inkscape/0.91.x r13853]
5. Bump our dependency level to Poppler >= 0.18.4
6. Kill the POPPLER_
[1] http://
Related branches
Changed in inkscape-devlibs: | |
importance: | Undecided → Wishlist |
status: | New → Triaged |
description: | updated |
description: | updated |
description: | updated |
description: | updated |
Changed in inkscape: | |
status: | Fix Committed → Fix Released |
Setting to "medium". Would be "wishlist", but I think the build failures with missing private headers qualify this as a bug.