MSI for Inskscape 0.91 incorrectly writing Registry under HKCU\Software\Microsoft

Bug #1418598 reported by Mark Leighton
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Low
theAdib

Bug Description

The Windows Installer package is tracking Start Menu and Desktop shortcut creation with Registry values located under HKCU\Software\Microsoft when it should be using keys specific to inkscape.org.

Suggested changes to inkscape.wxs

25c25
< <RegistryValue Root="HKCU" Key="Software\Microsoft\MyApplicationName" Name="installed" Type="integer" Value="1" KeyPath="yes"/>
---
> <RegistryValue Root="HKCU" Key="Software\inkscape.org\InkScape" Name="installed" Type="integer" Value="1" KeyPath="yes"/>
34c34
< <RegistryValue Root="HKCU" Key="Software\Microsoft\MyApplicationName" Name="installed" Type="integer" Value="1" KeyPath="yes"/>
---
> <RegistryValue Root="HKCU" Key="Software\inkscape.org\InkScape" Name="installed" Type="integer" Value="1" KeyPath="yes"/>

Related branches

Revision history for this message
Mark Leighton (mark-leighton) wrote :

Sorry, just realized the registry values were duplicates of each other too.

Corrected changes:

25c25
< <RegistryValue Root="HKCU" Key="Software\Microsoft\MyApplicationName" Name="installed" Type="integer" Value="1" KeyPath="yes"/>
---
> <RegistryValue Root="HKCU" Key="Software\inkscape.org\InkScape" Name="startmenu_installed" Type="integer" Value="1" KeyPath="yes"/>
34c34
< <RegistryValue Root="HKCU" Key="Software\Microsoft\MyApplicationName" Name="installed" Type="integer" Value="1" KeyPath="yes"/>
---
> <RegistryValue Root="HKCU" Key="Software\inkscape.org\InkScape" Name="desktop_installed" Type="integer" Value="1" KeyPath="yes"/>

jazzynico (jazzynico)
tags: added: packaging win32 win64
Revision history for this message
theAdib (theadib) wrote :

Hello Mark,
thank you for the hints. Please keep reporting when you have more observasions.
Regards, Adib.

Changed in inkscape:
assignee: nobody → theAdib (theadib)
importance: Undecided → Low
milestone: none → 0.91.1
status: New → In Progress
Revision history for this message
theAdib (theadib) wrote :

commited as http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/13910 on master
should be integrated into 0.91.1 release branch
Adib.

Changed in inkscape:
status: In Progress → Fix Committed
su_v (suv-lp)
tags: added: backport-proposed
Changed in inkscape:
milestone: 0.91.1 → 0.92
Revision history for this message
ScislaC (scislac) wrote :

Backported to 0.91.x in r13740.

tags: removed: backport-proposed
ScislaC (scislac)
Changed in inkscape:
milestone: 0.92 → 0.91.1
su_v (suv-lp)
tags: added: msi
jazzynico (jazzynico)
Changed in inkscape:
milestone: 0.91.1 → 0.92
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.