show/hide other layers not properly recorded in undo history

[Formerly Kevin Yin, now disabled]

Create a document with a few layers (for example, the attached). Open the undo history and layers dialog.

Right click on a layer and show/hide other layers. Then do it again for the same layer. Note that the undo history doesn't record the second time.

Seen on Inkscape 0.91 x64 on Windows 8.1.

[Liam P. White (liampwhite)]

Also verified with Inkscape 0.48.5 on Ubuntu Trusty.

[su_v (suv-lp)]

Match 'Importance' to similar earlier report concerning layer changes and undo history (bug #1256463).

Please comment if you disagree, or if this corrupts the undo history and can lead to crashes later on.

[jazzynico (jazzynico)]

From src/document-undo.cpp:

" * \verbatim
   void sp_document_done( SPDocument *document );
   void sp_document_maybe_done( SPDocument *document, const unsigned char *key ) \endverbatim
 *
 * Both move the recent action list into the undo stack and clear the
 * list afterwards. While the first method does an unconditional push,
 * the second one first checks the key of the most recent stack entry. If
 * the keys are identical, the current action list is appended to the
 * existing stack entry, instead of pushing it onto its own. This
 * behaviour can be used to collect multi-step actions (like winding the
 * Gtk spinbutton) from the UI into a single undoable step."

Thus calling DocumentUndo::done for SP_VERB_LAYER_SOLO and SP_VERB_LAYER_LOCK_OTHERS in verbs.cpp would add a different undo history entry each time the actions are performed instead of one (all actions can be undone with a single undo action) currently.

[jazzynico (jazzynico)]

Patch attached.

Could you please test and confirm the new behavior is correct?

[jazzynico (jazzynico)]

Fix committed revision 13572.