Update libavoid, libcola and libvpsc code

Bug #1353833 reported by jazzynico
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Wishlist
Unassigned

Bug Description

Follow-up to Bug #1155046 (Assertion `pathlen < 200' failed).

The Libavoid code embedded in the Inkscape code is quite old (connector.cpp is from 2009), and the upstream project is still alive as part of the Adaptagrams project (https://github.com/mjwybrow/adaptagrams).

It would be interesting to update our version as it probably fixes some connectors bugs.

su_v (suv-lp)
Changed in inkscape:
status: New → Confirmed
Revision history for this message
jazzynico (jazzynico) wrote : Re: Update Libavoid and Libcola code

While we're at it, we could also update Libcola (also in https://github.com/mjwybrow/adaptagrams).

summary: - Update Libavoid code
+ Update Libavoid and Libcola code
Revision history for this message
Alex Valavanis (valavanisalex) wrote :

As usual, the first step is a bit of archaeology... we need to identify:

1. The commit in the Adaptagrams repo at which we forked the code
2. The list of changes we have made since then:
2a. Which of these are minor/cosmetic (e.g., fixes for relatively harmless compiler warnings)?
2b. Can any patches be forwarded upstream?
2c. Do we need to maintain any Inkscape-specific patches?

jazzynico (jazzynico)
Changed in inkscape:
status: Confirmed → Triaged
Revision history for this message
jazzynico (jazzynico) wrote :

Some useful links:
* Last libavoid revision ported to Inkscape:
https://github.com/mjwybrow/adaptagrams/commit/412cfdfe87db311125eeef14c2c787ca2521f5ea (Commits on Sep 16, 2009)
* Last libcola revision ported to Inkscape:
https://github.com/mjwybrow/adaptagrams/commit/d807d1b9835880f0eb3143575857d8dcb1e54059 (Commits on Jul 17, 2006)

Of course libavoid and libcola changed a lot in Inkscape and upstream...

Revision history for this message
jazzynico (jazzynico) wrote :

And we also need to update libvpsc...

summary: - Update Libavoid and Libcola code
+ Update libavoid, libcola and libvpsc code
Revision history for this message
jazzynico (jazzynico) wrote :

Another related report: bug #1675779 "connector movement crash inkscape" (https://bugs.launchpad.net/inkscape/+bug/1675779).

Revision history for this message
Mc (mc...) wrote :

Maybe we can ask the adaptagrams author ? (if i'm not mistaken, he was the one implemetning it into inkscape)

Revision history for this message
Sylvain Chiron (frigory) wrote :

I’ve submitted a merge request for this bug:
https://gitlab.com/inkscape/inkscape/merge_requests/29

Revision history for this message
Alex Valavanis (valavanisalex) wrote :

Merged to master, 2017-07-01

Changed in inkscape:
status: Triaged → Fix Committed
milestone: 1.0 → 0.93pre0
Patrick Storz (ede123)
Changed in inkscape:
milestone: 1.0pre0 → 1.0
Max Gaukler (mgmax)
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.