trunk: randomized star/polygon changes shape when moved (rev >= 12554)

Bug #1348375 reported by su_v on 2014-07-24
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Inkscape
Medium
Liam P. White

Bug Description

A star/polygon with 'Randomized' parameter > 0 changes shape when moved (translated) on canvas.

Steps to reproduce:
1) launch current trunk (default prefs, default new document, locale: en_US)
2) draw a star
3) change parameter 'Randomized:' to e.g. 0.2
4) switch back to select tool
5) move the star (by dragging with the mouse, or with arrow keys)

Expected result:
The star shape is moved to new position, but stays unchanged otherwise.

Actual result:
The star shape is moved to the new position, and the shape gets regenerated (i.e. changes completely).

Based on tests with archived builds on OS X 10.7.5:
- not reproduced with stable 0.48.4, 0.48.5
- not reproduced with 0.48+devel rev <= 12552
- reproduced with 0.48+devel rev >= 12555
this perceived regression was likely introduced with the merge of the GSoC unit-improvement branch in r12554, which changed how transforms for parametrized shapes are optimized (if possibly, transforms get optimized and reflected in the shape parameters instead of stored in a preserved 'transform' attribute):
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/changes/12555>

Notes:
- non-uniform scaling, rotating or skewing the randomized star prevents the regression from happening (adds a 'matrix()' transformation)
- uniform scaling, or flipping the object does not prevent the regression

Reproduced with Inkscape 0.48+devel r13466 on OS X 10.7.5.

Related branches

su_v (suv-lp) on 2014-07-24
tags: added: shape-editing
su_v (suv-lp) on 2014-07-24
summary: - trunk: randomized star/polygon changes shape when moved
+ trunk: randomized star/polygon changes shape when moved (rev >= 12554)
description: updated
jazzynico (jazzynico) wrote :

Reproduced on Windows XP, Inkscape trunk revision 13484.

Changed in inkscape:
importance: Undecided → Medium
status: New → Triaged
Liam P. White (liampwhite) wrote :

As much as is it would be nice to have the star be transformed without storing an extra attribute, I think that having the ability to move the star without any changes (expected) probably outweighs that of optimizing the transform.

Fix committed in lp:inkscape, r13495.
Stars that are not randomized have their transforms optimized as usual.

Changed in inkscape:
status: Triaged → Fix Committed
assignee: nobody → Liam P. White (inkscapebrony)
su_v (suv-lp) wrote :

Initial fix (r13495) broke transforms of stars with default parameters - follow-up commits (r13498, 13499) revert the fix for bug #233935 with star/polygon shapes (stars that are not randomized have their transforms no longer optimized either).

Proposing to reopen this one, or to track the (partial) regression in new report.

Liam P. White (liampwhite) wrote :

Reopened.

Changed in inkscape:
status: Fix Committed → In Progress
Liam P. White (liampwhite) wrote :

I think it's been really fixed in r13500.

Changed in inkscape:
status: In Progress → Fix Committed
Bryce Harrington (bryce) on 2015-02-23
Changed in inkscape:
status: Fix Committed → Fix Released
su_v (suv-lp) wrote :

@LiamW - it seems that in the original report, and when testing the committed fix, I missed one specific use case of randomized stars which still regenerates a new result when transformed: uniform scaling (i.e. with locked ratio). Would you be willing/interested to take a closer look at this particular aspect?
* Bug #1482971 “randomized star/polygon changes shape when scaled with locked ratio (rev >= 12554)”
  https://bugs.launchpad.net/inkscape/+bug/1482971

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers