Tool parameter settings are shared between multiple documents

[Jabiertxof]

Pen/pencil modes -bezier, spiro and straights- are handled by a global preference shared between Inkscape instances.
So from 0.48 in advance if you have two or more instances, for example you can draw straight lines, when bezier toolbar button is selected.

Steps to reproduce:
Open two instances.
In one select straight lines
In other bezier ones.
In the straight instance draw a path.
Go to the other instance.
Now you have in the toolbar a bezier button selected but draw like you have selected straight button.

[Markus Engel (engelmarkus)]

I seem unable to come up with an elegant solution. Maybe this is a design flaw in how the tools are handled. Every time you switch the currently active tool, a new tool instance is created and the old one is destroyed.

If each window owned a set of tool instances that live as long as the window exists this wouldn't be a problem. Only on window creation every tool should read the prefs and when closing the window, every tool should write back its current state to the prefs. During window lifetime, a tool should only react to certain changes in the prefs (using the already existing PrefsObserver and the virtual set-method).

Currently, every change in a tool's settings is immediately written back to the prefs, e. g. in pencil-toolbar.cpp (sp_add_freehand_mode_toggle, freehand_mode_changed).

I'll try this out.

[Jabiertxof (jabiertxof)]

Hi Markus, good look and thanks for the quick reply. Tell me if i can help you. Regards, Jabier.

[su_v (suv-lp)]

AFAIU same issue as reported earlier in
- Bug #926191 “tool parameter settings are shared between multiple documents”
  <https://bugs.launchpad.net/inkscape/+bug/926191>

[Jabiertxof (jabiertxof)]

mark this as dupicate ~suv?

[su_v (suv-lp)]

On 2014-07-23 11:51 +0200, Jabiertxof wrote:
> mark this as dupicate ~suv?

Might make more sense now to link the older report as duplicate to this one (because Markus' comment here AFAIU better summarizes the issue and describes a possible solution).

[Jonathan Hofinger (jhofinger)]

Hi - thanks for reporting this bug, I've manually migrated it to Inkscape's new
bug tracker on GitLab, and closed it here.

Please feel free to file new bugs about the issues you're seeing at
http://inkscape.org/report.

Moved to: https://gitlab.com/inkscape/inbox/issues/1538
Closed by: https://gitlab.com/jhofinger