trunk: crash on paste from clipboard, and on file import (rev >= 13299)

[su_v]

Current trunk crashes when pasting an object from the clipboard, or when importing an SVG file.

Steps to reproduce:
1) launch latest trunk (default new prefs, default new doc)
2) draw a rectangle
3) copy it (Ctrl+C)
4) paste it (Ctrl+V)

Expected result:
The copied object is pasted at the current pointer position.

Actual result:
Crash on paste.

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_INVALID_ADDRESS at address: 0x0000000214e0d070
0x00000001008a7080 in SPIPaint::isPaintserver (this=0x214e0d048) at style-internal.h:494
494 bool isPaintserver() const {return (value.href) ? value.href->getObject():0;}

On OS X 10.7.5:
- not reproduced with rev <= 13297
- reproduced with r13299, r13301
(the crash occurs with X11- and with Quartz-backend of GTK+).

[su_v (suv-lp)]

Likely also affects import from openclipart (can't verify myself due to bug #943148).

[jazzynico (jazzynico)]

Also reproduced on Crunchbang Waldorf, Inkscape trunk revision 13301.

> Likely also affects import from openclipart

Confirmed.

[su_v (suv-lp)]

Also affects import of bitmap images (via 'File > Import' or drag&drop onto canvas), and other file formats (e.g. PDF).

[Shlomi Fish (shlomif-gmail)]

This is a patch that appears to fix the bug for me. The problem was that SPIPaint_properties and SPIPaint_members were not synchronised.

[su_v (suv-lp)]

Patch tested successfully with r13301 on OS X 10.7.5

[su_v (suv-lp)]

@Tav - any chance you could review and commit the patch for this regression if ok?

[Tavmjong Bah (tavmjong-free)]

Committed (13302) with an additional line commented out. Thanks Shlomi.

The 'color' attribute can only hold a color value and not a paint value (e.g. pattern) per SVG1.1/CSS2.1

[su_v (suv-lp)]

@Shlomi and @Tav - thx a lot for the quick fix!

[su_v (suv-lp)]

@Tav - any chance could you review another proposed patch related to the recent changes for SPStyle, to address overzealous warnings from clang about mismatched tags (struct or class)?
<https://bugs.launchpad.net/inkscape/+bug/1232425> comment #13