resize page to drawing resets unit to px (rev >= 12554)

[Sam Petrocelli]

File -> Document Properties. In "Custom Size" box area select "mm" in "units" combobox. Click the "resize page to drawing or selection" and the units combobox resets to "px" and the page width/height dimensions also reset to "px" scale.

I am running Fedora 20 with Inkscape 0.48+devel r13293.

[Alvin Penner (apenner)]

- not reproduced on Windows XP, Inkscape rev 13288
- not reproduced on Windows 7, Inkscape 0.48.4

[su_v (suv-lp)]

On OS X 10.7.5:
- not reproduced with Inkscape 0.48.4 r9939
- reproduced with Inkscape 0.48+devel r13294

[Alvin Penner (apenner)]

sorry about that, now I am reproducing it as well on rev 13288. I had forgotten to actually select an object to resize to, doh.

[su_v (suv-lp)]

Based on tests with archived builds on OS X 10.7.5:
- not reproduced with rev <= 12552,
- reproduced with rev >= 12555;
the regression was likely introduced with the merge of the unit improvement branch in r12554:
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/12554>

[Alvin Penner (apenner)]

fix committed to rev 13590

[su_v (suv-lp)]

@Alvin - in revision 13715 <lp:inkscape> you modified the fix applied in rev 13590 in <lp:inkscape> for this report (bug #1310787) - does this fix need to be backported to the stable release branch 0.91.x <lp:inkscape/0.91.x> too? Can - or should - it be considered for backporting at all?

[Alvin Penner (apenner)]

good question, I think the answer is yes, it would be a good idea to backport the new fix. I ran into this by accident. I was using the file default.svg from trunk, which is different than the previous default.svg file, because everything is now in mm. This file has a minor inconsistency in that the variable 'units' in the namedview section is missing. That fact that it is missing is not important because it is redundant and should be removed anyways. But I was using this variable and was mis-identifying the units because of it. So I switched to using the units obtained from the height specification in root. This is foolproof as far as I can tell. Anyways the same comment applies to 91.x as well. I downloaded default_mm.svg from .91x and encountered the same issue, so it would be worthwhile to backport it there as well.

[su_v (suv-lp)]

Second part of the fix (revision 13715) needs to be backported to 0.91.x, setting milestone to 0.92 for now.

[ScislaC (scislac)]

fix backported in 0.91.x r13663

[su_v (suv-lp)]

Follow-up report (regression related to rev 13715):
- Bug #1419122 ""resize page to selection" broken in 0.91 with width="100%", height="100%"”
  https://bugs.launchpad.net/inkscape/+bug/1419122