trunk fails to build with CMake due to some lib2geom CMakeLists.txt problems

Bug #1283174 reported by Shlomi Fish on 2014-02-21
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Undecided
Shlomi Fish

Bug Description

The Inkscape trunk ( revno: 13045 ) fails to build on Linux using CMake+ninja due to missing or additional files under src/2geom/CMakeLists.txt . The attached tentative patch fixes the problem , but there's a README warning about changing the lib2geom copy in the inkscape repository directly, because they will get overwritten. It seems the problem was corrected in the lib2geom sources though.

su_v (suv-lp) on 2014-02-21
tags: added: build cmake
tags: added: 2geom
Shlomi Fish (shlomif-gmail) wrote :

This is an up-to-date patch that fixes more problems since this bug was filed. Please apply it.

Johan Engelen (johanengelen) wrote :

we don't use cmake per default, which is why the build lists are not kept in sync, i'm sorry.
your patch committed in rev. 13267.

Changed in inkscape:
assignee: nobody → Johan Engelen (johanengelen)
status: New → Fix Released
Shlomi Fish (shlomif-gmail) wrote :

Hi Johan,

cmake still fails to build Inkscape. I noticed that the 2geom part of the patch was omitted from the commit, and after I add it, the build is successful. Here is an up-to-date patch.

Regards,

-- Shlomi Fish

su_v (suv-lp) wrote :

@Shlomi - could you please confirm that this still requires fixing in trunk (patch from comment #4)? I'll reopen the report if this is the case.

Shlomi Fish (shlomif-gmail) wrote :

@suv: yes, it still requires fixing in trunk.

su_v (suv-lp) on 2014-04-26
Changed in inkscape:
assignee: Johan Engelen (johanengelen) → Shlomi Fish (shlomif-gmail)
status: Fix Released → In Progress
su_v (suv-lp) wrote :

Last part of the fix committed in rev 13308 - thx, Shlomi!

Changed in inkscape:
status: In Progress → Fix Released
Shlomi Fish (shlomif-gmail) wrote :

Thanks and you're welcome.

Regards,

-- Shlomi Fish

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers