trunk: selection cue can no longer be turned off per tool (rev >= 12532)

[su_v]

Each tool has a preference setting to turn off the selection cue in the tool context. The setting has no longer an effect in trunk: The selection cue is always displayed, independent of the tool setting.

Based on tests with archived builds on OS X 10.7.5:
- not reproduced with rev <= 12531
- reproduced with rev >= 12532
this feature got lost with the merge of the C++ification branch in revision 12532:
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/12532>

[jazzynico (jazzynico)]

Confirmed on Windows XP, Inkscape trunk revision 12980.

> The selection cue is always displayed, independent of the tool setting.

Not exactly. It seems that the preference works as expected with the Node and Zoom tools, but fails with the others.

[su_v (suv-lp)]

> It seems that the preference works as expected with the Node

In my tests it is not consistent, and does not stick across sessions. Sometimes I seem to be able to make it work for the node tool in the current session if I change the setting right after launching inkscape.

[Markus Engel (engelmarkus)]

The selcue setting is only read when you switch the current tool, not when you check or uncheck the actual setting.
I think the only tool the selcue setting does not work for is the selection tool. But there it didn't even work in 0.48.4.

[su_v (suv-lp)]

Steps to consistently reproduce current regression (apparently triggered e.g. by pen and pencil tools):

1) rename current prefs file (to start from scratch)
2) launch current trunk (empty new doc)
3) open preferences: turn off selcue for the shape tools
4) quit

5) launch trunk with prefs as set in step 3
6) draw an ellipse (OK: no selcue for this tool)
7) switch to any of the other shape tools (ok: selcue remains off)
8) draw a path with the pen or pencil tool (ok: selcue is on for these tools)
9) switch back to any shape tool
--> fail: selcue is incorrectly on

10) open preferences: turn off selcue for pen tool
11) quit and launch again (to start with clean session)

12) draw an ellipse (ok: selcue is off)
13) draw a path with the pen tool (ok: selcue is off for this tool))
14) switch to any shape tool (ok: selcue is still off)
15) draw a path with pencil tool (ok: selcue is on for this tool)
16) switch to any shape tool
--> fail: selcue is incorrectly on

17) open duplicate window
18) switch to any shape tool (ok: in this window, the selcue is still off)
19) draw a path with the pencil tool (ok: selcue is on for this tool)
20) switch to any shape tool
--> fail: now the selcue is on incorrectly in the duplicate window too

[Markus Engel (engelmarkus)]

Seems like I forgot some clean up code. This should fix it.

[su_v (suv-lp)]

Patch tested successfully with r13044 on OS X 10.7.5.

[Markus Engel (engelmarkus)]

Fixed in r13051.

[su_v (suv-lp)]

Thx :)