DrawingContext, all ct to dc

Bug #1272073 reported by David Mathog on 2014-01-23
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Wishlist
David Mathog

Bug Description

In various sections of the code DrawingContext objects were given the name "ct", which was confusing because within the same source modules the name "ct" was also used for cairo_t variables. The attached patch changes all DrawingContext "ct" (or "_ct" ) to "dc" (or "_dc") . Additionally the few instances of "bgct" where changed to "bgdc".

This should have no effect whatsoever on the compiled code, but it is less confusing when working in those modules since after the patch each name is only ever used for one data type.

David Mathog (mathog) wrote :
su_v (suv-lp) wrote :

On 2014-01-23 22:16 +0100, mathog wrote on 'inkscape-devel':
> If somebody could verify that it works on a Mac (…)

r12975+ patch compiled successfully on OS X 10.7.5 [1].

--
[1] tested with llvm-gcc-4.2 and with (outdated) clang from Xcode 4.3.2 on OS X 10.7.5

Note that for tests with newer clang from latest Xcode 5.0.2 on current OS X 10.9 Mavericks (uses libc++ instead of libstcd++), in case of build breakage, we'll have for now to rely e.g. on feedback provided by the port maintainer of the inkscape-devel port in MacPorts (and the build result of the MacPorts build-bots), once the changes have been committed to trunk.

Changed in inkscape:
importance: Undecided → Wishlist
milestone: none → 0.91
jazzynico (jazzynico) wrote :

Patch tested successfully on Windows XP, Inkscape trunk revision 12994.

Changed in inkscape:
assignee: nobody → David Mathog (mathog)
status: New → In Progress
jazzynico (jazzynico) on 2014-02-03
tags: added: code-quality
jazzynico (jazzynico) on 2014-02-03
tags: added: code-design
removed: code-quality
su_v (suv-lp) wrote :
Changed in inkscape:
status: In Progress → Fix Committed
Bryce Harrington (bryce) on 2015-02-21
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers