The toolbox buttons toggle between being pressed and released

[Cojnel]

The tool is still active and works normally,
it's just a ui problem.

If one clicks on a button once,
then it becomes pressed as one would expect,

but if one clicks on the same button again,
then it becomes released and it looks like none of the tools are active.

In v0.48.4 r9939 the buttons stay pressed,
no matter how many times one clicks on them.

Tested with r12945
on linux mint 15 32bit

[su_v (suv-lp)]

Reproduced with r12952 on OS X 10.7.5.

Based on tests with archived builds:
- not reproduced with rev <= 12931,
- reproduced with rev >= 12933,
this GUI regression seems to have been introduced with the changes in revision 12932:
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/changes/12933>

[jazzynico (jazzynico)]

> this GUI regression seems to have been introduced with the changes in revision 12932.

Confirmed.
Patch attached (tested on Windows XP only, revision 12960).

[su_v (suv-lp)]

Patch tested successfully with r12960 on OS X 10.7.5. Any potential side-effects to watch out for?

[jazzynico (jazzynico)]

Thanks for your test!

 > Any potential side-effects to watch out for?

Except regressions regarding Bug #1268778, I don't see any. It should be quite easy to test (play with the shortcuts and the icons) and not risky, but that report is the proof there's always a place for a bug anywhere...

[jazzynico (jazzynico)]

Fixed (let's be optimistic) revision 12961.