'Move' cursor disappears after clicking on Select Tool (F1) twice (rev >= 12532)

Bug #1268778 reported by Alvin Penner on 2014-01-13
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Medium
jazzynico

Bug Description

- Windows XP, Inkscape rev 12921
- draw an object
- click on Select Tool (F1)
- move/hover cursor over the object boundary and get the 'Move' cursor which indicates that the object can be dragged (normal arrow plus extra cross-hair symbol)
- click again on Select Tool (F1)
- move/hover cursor over the object boundary and get no change in cursor. The object actually can be dragged, but the cursor does not indicate that it can be dragged.

- to recover the Move cursor, click on some other tool like Node Tool (F2)
- then click on (F1) and hover and the Move cursor will reappear

- not reproduced on Inkscape 0.48.4

su_v (suv-lp) wrote :

Confirmed with r12923 on OS X 10.7.5.

Based on tests with archived builds:
- not reproduced with rev <= 12531
- reproduced with rev >= 12532
the changed behavior seems to have been introduced with the merge of the C++-ification branch in rev 12532:
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/12532>

tags: added: regression ui
Changed in inkscape:
importance: Undecided → Medium
milestone: none → 0.91
status: New → Confirmed
su_v (suv-lp) on 2014-01-13
summary: - 'Move' cursor disappears after clicking on Select Tool (F1) twice
+ 'Move' cursor disappears after clicking on Select Tool (F1) twice (rev
+ >= 12532)
su_v (suv-lp) on 2014-01-13
tags: added: selection
jazzynico (jazzynico) on 2014-01-14
Changed in inkscape:
assignee: nobody → jazzynico (jazzynico)
status: Confirmed → In Progress
jazzynico (jazzynico) wrote :

When clicking on a new tool, the old one is deleted after the new one is constructed.
Not a problem with most tools (except the fact that it's not very clean), but in our case, the destructor resets the pixmap cursors to NULL:
1. Selector active.
2. Selector clicked.
3. Selector constructor called.
4. Selector destructor called (no more cursors!).
5. Selector setup called.
6. Selector active (without cursors).

Patch attached. Tested successfully on Windows XP, Inkscape trunk revision 12923.

su_v (suv-lp) wrote :

Patch tested successfully with r12926 on OS X 10.7.5 (GTK+/X11 2.24.13, GTK+/Quartz 2.24.22).

AFAICT the remaining issue (re-activating the select tool while hovering a selectable object still switches to the system cursor - to refresh the cursor symbol, the pointer needs to be moved across an empty canvas area, or one of the transformation handles first) is old (also present e.g. in 0.47), and not a recent regression.

su_v (suv-lp) wrote :

> (…) the remaining issue (re-activating the select tool while hovering a selectable (…)

This refers to re-activating the select tool with the keyboard shortcut ('S' or <F1>), not by clicking on the toolbox icon.

jazzynico (jazzynico) wrote :

> (…) the remaining issue (re-activating the select tool while hovering a selectable (…)

Yes, I noticed it too. Not sure there's something obvious we can do. It's not too serious though.

jazzynico (jazzynico) wrote :

Fixed in the trunk, revision 12931.
Thanks for your test, ~suv!

Changed in inkscape:
status: In Progress → Fix Committed
jazzynico (jazzynico) wrote :

Just woke up with a new idea...
Better patch (fixing the remaining issue) in progress.

jazzynico (jazzynico) wrote :

The new patch sets a new tool if it is different from the old one only.

su_v (suv-lp) wrote :

1268778-MoveCursor+.diff tested successfully with r12931 on OS X 10.7.5.

I noticed yet another situation exposing the system cursor (with unpatched and patched trunk):
1) draw rect, hover it with the mouse
2) toggle to dropper tool
3) toggle back to select tool

--> after returning to the select tool the pointer uses the system cursor until it has been moved across the edge of a selectable object.

Is the second patch is fixing it at the right place? The same symptom seems to occur with more than one workflow.

jazzynico (jazzynico) wrote :

Patch from comment #8 committed revision 12932.

su_v (suv-lp) wrote :

Follow-up report (regression with toolbox buttons):
- Bug #1270287 “The toolbox buttons toggle between being pressed and released”
  <https://bugs.launchpad.net/inkscape/+bug/1270287>

su_v (suv-lp) wrote :

On 2014-01-15 13:18 +0100, ~suv wrote:
> I noticed yet another situation exposing the system cursor (with
> unpatched and patched trunk):
> 1) draw rect, hover it with the mouse
> 2) toggle to dropper tool
> 3) toggle back to select tool
>
> --> after returning to the select tool the pointer uses the system
> cursor until it has been moved across the edge of a selectable object.

Already tracked in bug #1062673.

jazzynico (jazzynico) on 2015-02-14
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers