crossing.h:121: possible bad > expression ?

Bug #1263191 reported by dcb on 2013-12-20
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Low
Unassigned
lib2geom
Medium
Krzysztof Kosinski

Bug Description

I just ran the static analysis tool "cppcheck" over the
source code of inkscape-0.48.4. It said many things,
including

[2geom/crossing.h:121] -> [2geom/crossing.h:121]: (style) Same expression on both sides of '>'.

Source code is

            return (ix == a.a ? a.ta : a.tb) >
                   (ix == a.a ? a.ta : a.tb);

Suggest code rework.

Kris (kris-degussem) on 2013-12-20
Changed in inkscape:
status: New → Triaged
importance: Undecided → Low
su_v (suv-lp) on 2015-08-08
tags: added: code-design
Krzysztof Kosinski (tweenk) wrote :

This is fixed in r2423. These classes will eventually be removed since they are badly written and not very useful.

Changed in lib2geom:
status: New → Fix Committed
importance: Undecided → Medium
assignee: nobody → Krzysztof Kosinski (tweenk)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers