Re-ordered filter list not saved to XML

[su_v]

Steps to reproduce:
1) move your current preferences file aside (important)
2) launch inkscape
3) open attached file
4) open XML Editor
5) open Filter Editor
--> watch and wait
6) close both dialogs
7) quit inkscape
--> watch and wait (if you are lucky), or kill the process (if it hangs indefinitely with high CPU usage)

Confirmed with r12679 on OS X 10.7.5 and r12678 on Ubuntu 13.04.

Based on tests with archived builds (on OS X):
- not reproduced with rev <= 12392
- reproduced with rev >= 12395
it seems likely that this regression was introduced in
- Revision 12394: Add the ability to reorder filters using drag-drop in the gtklist
  <http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/12394>

For timed tests on the command line (to verify that the problem only occurs when both dialogs are opened):
# make backup of user prefs (important)
mv $HOME/.config/inkscape/preferences.xml{,-bkp}

# test each dialog separately
time inkscape -f ./performance-xml-and-filter-editor-1.svg --verb=DialogXMLEditor --verb=FileQuit
# remove prefs file for each test (important)
rm $HOME/.config/inkscape/preferences.xml
time inkscape -f ./performance-xml-and-filter-editor-1.svg --verb=DialogFilterEffects --verb=FileQuit

# tests combined
rm $HOME/.config/inkscape/preferences.xml
time inkscape -f ./performance-xml-and-filter-editor-1.svg --verb=DialogXMLEditor --verb=DialogFilterEffects --verb=FileQuit

# when done, restore user prefs
cp $HOME/.config/inkscape/preferences.xml{-bkp,}

[jazzynico (jazzynico)]

Confirmed on Windows XP, Inkscape trunk revision 12686.

[su_v (suv-lp)]

Setting bug status to 'High' for now - since some of the filter primitives parameters are either not accessible via GUI [1] or only allow a limited range of values via GUI [2], using the XML Editor parallel to the Filter Effects Editor is a regular use case which seems to fail now as soon as there's a decent amount of filter definitions in the <defs> section. There is also the risk of data loss on quit (if the hanging process is killed).

[1] e.g. feComponentTransfer
[2] see also bug #713056, bug #713050 and this message on the mailing list:
<http://article.gmane.org/gmane.comp.graphics.inkscape.devel/34576>

[Johan Engelen (johanengelen)]

Disable a part of r12394 that caused the infinite loop (?).
Reordering of filter list is broken, and seems better not to act upon reordering than hanging Inkscape.
Committed this "fix" in r13055

[Johan Engelen (johanengelen)]

Changing importance to Low and removing the milestone. The bug is now: re-ordered filter list not saved.

[su_v (suv-lp)]

@Johan - why not close this one, and reopen bug #1168814 instead? How much of the requested feature in bug #1168814 does still exist in current trunk?