trunk: node tool cursor symbol (cursor_node_d_xpm) lost white outline and fill (rev >= 12532)

[su_v]

The cursor symbol of the node tool when hovering a dragable path segment lost its white outline and fill which makes it hard to see over dark backgrounds.

Steps to reproduce:
1) launch current trunk (default prefs, default new doc)
2) draw a rect (default fill: blue)
3) convert to path
4) switch to the node tool, grab & drag the path segment at the top

Expected result:
The cursor symbol is clearly visible even if over a darker background.

Actual result:
The cursor symbol only renders the black colors of the pixmap and is hardly visible over a darker background.

Reproduced with r12650 on Ubuntu 13.04 (inkscape-trunk PPA) and r12654 on OS X 10.7.5 (X11 as well as Quartz backend)

Tests with archived builds on OS X 10.7.5:
- not reproduced with rev 12531 and earlier builds
- reproduced with r12532 and later builds,
indicate that this regression was introduced with the merge of the C++ification of the SP tree in r12532:
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/12532>

[jazzynico (jazzynico)]

Confirmed on Windows XP, Inkscape trunk revision 12667.

[Markus Engel (engelmarkus)]

Quite strange, I didn't even change this file... try the attached patch.

[su_v (suv-lp)]

> Quite strange, I didn't even change this file...

No, but you changed code for the node tool:
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/12532#src/ui/tool/node-tool.cpp>

[su_v (suv-lp)]

Patch tested successfully with r12670 on OS X 10.7.5: the solid white areas of that node cursor symbol render as expected.

Just curious - does the XPM file format require upper-case hex values?
(r9646 seems to have introduced the lowercase #ffffff values …)

[Markus Engel (engelmarkus)]

I know I changed the node tool itself, but I didn't touch the xpm parser ;) .
It seems this upper case #FFFFFF is necessary, yes. But I don't know why this has worked before.

[Markus Engel (engelmarkus)]

Fixed in r12674.