Can not draw a rect inside another rect (shape creation)

Bug #1228393 reported by Martin Owens on 2013-09-20
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Medium
Markus Engel

Bug Description

When trying to draw a rectangle using r12556, the first rect is fine. But any rect I try and draw starting inside the existing shape fail. Instead Inkscape now selects the first rect.

This stops people from drawing multiple shapes together and stops rects being used as backgrounds.

su_v (suv-lp) wrote :

Reproduced with r12555 on OS X 10.7.5

Testing with archived builds:
- works with rev <= 12531
- fails with rev >= 12532

AFAICT only affects the rectangle tool (ellipse/circle and star/polygon tool not affected).

tags: added: regression selection shape-editing
Changed in inkscape:
importance: Undecided → Medium
milestone: none → 0.49
status: New → Triaged
su_v (suv-lp) wrote :

@Markus - any chance you could take a look at this regression with the rectangle tool?

Markus Engel (engelmarkus) wrote :

Of course I will... I've already got an idea where this happens. Some parts of the event context code looked really weird.

Markus Engel (engelmarkus) wrote :

This fixes it. Now ask yourself: why is ret assigned inside the switch, when it's unconditionally overwritten by the base class method call right under it? Some other item_handlers have got this check there, some haven't. I marked the other missing ifs with a comment only, but this one I added. I don't know why ;) .

su_v (suv-lp) wrote :

Patch tested successfully with r12557.

@Markus - do you already have commit access?

Changed in inkscape:
assignee: nobody → Markus Engel (engelmarkus)
status: Triaged → In Progress
Markus Engel (engelmarkus) wrote :

> @Markus - do you already have commit access?

No, I don't. May I hereby apply for commit access? ;)

Markus Engel (engelmarkus) wrote :

I fixed it in r12561.

Changed in inkscape:
status: In Progress → Fix Committed
su_v (suv-lp) wrote :

@Markus - welcome to the dev team :)

Changing bug status to 'Fix Released' in accordance with
<http://wiki.inkscape.org/wiki/index.php/Bug_management#Bug_status>
(«(…) use this status for bugs that only appeared in the development version, and were never encountered in a stable release.»)

Changed in inkscape:
milestone: 0.49 → none
status: Fix Committed → Fix Released
Markus Engel (engelmarkus) wrote :

Ah, thanks a lot!

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers