Compiling error: CLIPBOARD_WIN32_EMF_TARGET not declared

[LucaDC]

Get this error when compiling rev. 12500 on Windows XP SP3:

Make error line 298: problem compiling: src/ui/clipboard.cpp: In member function 'Glib::ustring Inkscape::UI::ClipboardManagerImpl::_getBestTarget()':
src/ui/clipboard.cpp:1245:20: error: 'CLIPBOARD_WIN32_EMF_TARGET' was not declared in this scope
src/ui/clipboard.cpp:1253:16: error: 'CLIPBOARD_WIN32_EMF_TARGET' was not declared in this scope
src/ui/clipboard.cpp: In member function 'void Inkscape::UI::ClipboardManagerImpl::_setClipboardTargets()':
src/ui/clipboard.cpp:1317:42: error: 'CLIPBOARD_WIN32_EMF_MIME' was not declared in this scope

Also after a clean rebuild.

[su_v (suv-lp)]

@Krzysztof - could you please take a look? AFAICT not all uses of 'CLIPBOARD_WIN32_EMF_TARGET' and 'CLIPBOARD_WIN32_EMF_MIME' have been substituted in r12500.

[jazzynico (jazzynico)]

Confirmed on Windows XP, Inkscape trunk revision 12501.

[LucaDC (lucadc)]

For now I've just reinserted the two lines:

#define CLIPBOARD_WIN32_EMF_TARGET "CF_ENHMETAFILE"
#define CLIPBOARD_WIN32_EMF_MIME "image/x-emf"

and so I could compile.

I think that the right solution would be to copy the various strings in the correct places as the #defines are not applicable in the new code (in particular in the if with the or) and should be deleted.

On a side note, in the same file I've found this comment in function Glib::ustring ClipboardManagerImpl::_getBestTarget():

// If both bitmap and metafile are present, pick the one that was exported first.

Couldn't this be the source of the problem of when a bitmap paste is done also for a vectorial copied objects?
Instead of giving precedence to the first exported, shouldn't it be given to the metadata, if present?

[su_v (suv-lp)]

See also:
<http://thread.gmane.org/gmane.comp.graphics.inkscape.devel/41244>
<http://thread.gmane.org/gmane.comp.graphics.inkscape.devel/41287>

Fixed in revision 12507
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/12507>