cxxtest: svg-length-test.h fails

Bug #1208002 reported by Alex Valavanis on 2013-08-03
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Medium
Matthew Petroff

Bug Description

In lp:inkscape r12445, svg-length-test.h fails in "make check".

One issue appears to be that "123 px" (with a space before the unit) is supposed to fail in len.read("123 px"), but this does not happen.

@Matthew Petroff - this sounds like it might be of interest to your GSoC project?

In SvgLengthTest::testRead:
../../src/svg/svg-length-test.h:51: Error: Test failed: 123 px
../../src/svg/svg-length-test.h:51: Error: Assertion failed: !len.read(fail_tests[i])
In SvgLengthTest::testReadOrUnset:
../../src/svg/svg-length-test.h:75: Error: Test failed: 123 px
../../src/svg/svg-length-test.h:75: Error: Expected (len.unit == SVGLength::INCH), found ({ 00 00 00 00 } != { 06 00 00 00 })
../../src/svg/svg-length-test.h:77: Error: Test failed: 123 px
../../src/svg/svg-length-test.h:77: Error: Expected (len.computed == 456), found (123.0000 != 456)
In SvgLengthTest::testReadAbsolute:
../../src/svg/svg-length-test.h:96: Error: Test failed: 123 px
../../src/svg/svg-length-test.h:96: Error: Assertion failed: !len.readAbsolute(fail_tests[i])

Changed in inkscape:
importance: Undecided → Medium
status: New → Triaged

I fixed it in my GSoC branch, which should be merged with the trunk soon.

Changed in inkscape:
assignee: nobody → Matthew Petroff (matthewpetroff)
status: Triaged → In Progress

Fixed in r12471.

Changed in inkscape:
status: In Progress → Fix Released
Changed in inkscape:
status: Fix Released → Confirmed
Johan Engelen (johanengelen) wrote :

I have reverted this change in r12506, as it created bug 1215575.

Changed in inkscape:
assignee: Matthew Petroff (matthewpetroff) → nobody

I fixed it again in r12508. Now it checks for a letter following the space instead of just the space, avoidings the regressions introduced by the original fix.

Changed in inkscape:
status: Confirmed → Fix Released
assignee: nobody → Matthew Petroff (matthewpetroff)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers