cxxtest: attributes-test.h fails

Bug #1202237 reported by Alex Valavanis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Medium
Alex Valavanis

Bug Description

The attributes-test.h unit test currently fails with lp:inkscape r12423. Build log from "make check" shows:

In AttributesTest::testAttributes:
../../src/attributes-test.h:477: Error: Test failed: "path"
../../src/attributes-test.h:477: Error: Expected (recognized == all_attrs[i].supported), found (true != false)
../../src/attributes-test.h:477: Error: Test failed: "inkscape:snap-from-guide"
../../src/attributes-test.h:477: Error: Expected (recognized == all_attrs[i].supported), found (false != true)
../../src/attributes-test.h:520: Warning: "Attribute string with enum 8 {inkscape:connection-points} not handled"
../../src/attributes-test.h:520: Warning: "Attribute string with enum 45 {fit-margin-top} not handled"
../../src/attributes-test.h:520: Warning: "Attribute string with enum 46 {fit-margin-left} not handled"
../../src/attributes-test.h:520: Warning: "Attribute string with enum 47 {fit-margin-right} not handled"
../../src/attributes-test.h:520: Warning: "Attribute string with enum 48 {fit-margin-bottom} not handled"
../../src/attributes-test.h:520: Warning: "Attribute string with enum 84 {units} not handled"
../../src/attributes-test.h:520: Warning: "Attribute string with enum 99 {inkscape:connection-start-point} not handled"
../../src/attributes-test.h:520: Warning: "Attribute string with enum 100 {inkscape:connection-end-point} not handled"
../../src/attributes-test.h:520: Warning: "Attribute string with enum 202 {osb:paint} not handled"
../../src/attributes-test.h:520: Warning: "Attribute string with enum 205 {tensor} not handled"
../../src/attributes-test.h:525: Error: Assertion failed: !found

I have attached a patch that simply updates the list of attributes in the test. Please could someone with better knowledge of attribute handling check this to ensure that I haven't done anything stupid (i.e., labelling an attribute as "supported" when it isn't or vice versa).

I will commit the patch in a couple of days if there are no objections.

Tags: build
Revision history for this message
Alex Valavanis (valavanisalex) wrote :
Revision history for this message
Alex Valavanis (valavanisalex) wrote :

Patch committed to test in r12444. If I've messed anything up, please feel free to correct/revert!

Changed in inkscape:
milestone: none → 0.49
status: In Progress → Fix Committed
Bryce Harrington (bryce)
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.