Export as DXF with layer selection improvement (all, visible, by name)

Bug #1164904 reported by Yann Papouin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Wishlist
Yann Papouin

Bug Description

Hi,

I have added export by name support to dxf_outline extension.
I've removed previously added "visibleLayers" option that is now embedded in the new layer_option.
Now you can choose to export all layers, only visible ones or by name match (case insensitive and use comma ',' as separator)

See files attached

Tags: dxf exporting
Revision history for this message
Yann Papouin (yann-papouin) wrote :
Revision history for this message
Alvin Penner (apenner) wrote :

thanks for the contribution!
I have tested it and confirmed that it behaves correctly if one uses the option 'By name match', and if one specifies a layer name that actually exists.

However, there are two cases where it does not behave as expected.
case 1, use the option 'By name match', and leave the layer name blank. In this case it sends all layers to output, when I would have expected none.
case 2, deliberately misspell a layer name so no match is found. In this case I get the attached error message, saying it failed to save the file.

In both of these cases, I think it would be preferable to raise an information window, using something like inkex.errormsg, and indicate to the user that no layer name match was found, and ask them to try again.

Revision history for this message
Yann Papouin (yann-papouin) wrote :

Ok that should not be difficult, I'm looking into this.
Thanks for your review.

Revision history for this message
Yann Papouin (yann-papouin) wrote :

Updated!

- case 1, an error message is now displayed if 'Layer match name' field is empty, and the export process is canceled.
- case 2, a warning message is displayed if no match is found for a layer name, but the export will process successfully

Revision history for this message
Alvin Penner (apenner) wrote :

thanks, tested and committed to rev 12273

Changed in inkscape:
status: New → Fix Committed
su_v (suv-lp)
Changed in inkscape:
assignee: nobody → Yann Papouin (yann-papouin)
importance: Undecided → Wishlist
milestone: none → 0.49
su_v (suv-lp)
tags: added: dxf exporting
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.