GTK3: Build failure with r12119

Bug #1122816 reported by su_v
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
High
honkir

Bug Description

Revision 12119 fails to build with experimental GTK3:

  CXX device-manager.o
../../src/device-manager.cpp: In member function ‘virtual void Inkscape::DeviceManagerImpl::loadConfig()’:
../../src/device-manager.cpp:381: error: ‘Glib::Regex’ has not been declared
../../src/device-manager.cpp:393: error: ‘Glib::Regex’ has not been declared
make[3]: *** [device-manager.o] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

Build failure occurs with:
- OS X 10.7.4, GTK+/X11 3.4.4, gtkmm 3.4.0, glib 2.32.4
- OS X 10.7.4, GTK+/Quartz 3.6.4, gtkmm 3.6.0, glib 2.34.3

Earlier revisions up to r12118 built successfully with GTK3, and all revisions built ok with GTK2.

Tags: build gtk3
su_v (suv-lp)
description: updated
Revision history for this message
honkir (honkir) wrote :

Easy fix for GTK3 version:
Add #include <glibmm/regex.h> to device-manager.cpp. I do not have rights to to that, so please...
Note - I haven't tested the GTK2 version.

Revision history for this message
honkir (honkir) wrote :

Sorry, previous set wasn't nearly enough, seems that "a couple of forward declarations" broke a lot of modules. Patch as attachment. Compiles also without gtk3 enabled for me.

Revision history for this message
Alex Valavanis (valavanisalex) wrote :

Thanks for the patch and sorry I didn't get time to fix things sooner. Will test and commit tomorrow hopefully if no one beats me to it.

Changed in inkscape:
status: New → Triaged
importance: Undecided → High
status: Triaged → In Progress
Revision history for this message
Alex Valavanis (valavanisalex) wrote :

Patch works with Gtk+ 3 and Gtk+ 2 builds. Many thanks, and apologies for the slow sponsorship! :-)

Applied in lp:inkscape r12145

Changed in inkscape:
assignee: Alex Valavanis (valavanisalex) → honkir (honkir)
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.