Filter editor: only show relevant light source parameters for lighting filter primitives (rev >= 10957)

[v1nce]

when switching from 0.48.3 to 0.48-devel-12005-37 I see some "regression" in lighting filter

now the parameters for all type of light source(distant,point,spot) are visible at once.

this is bad. it eats so much space while there is so little for filter lists which is the core of the dialog.

can this be reverted to 0.48.3 ? or can one replace the light source dropdown with 3 tabs ?

by the way if one source of lighti (distant ?) could be selected by default it would be great (who wants to create a feDiffuseLighting without a lightsource ?)

[v1nce (vincent-pennec)]

please someone rewrites title as "[wish] light source parameters eat too much space (0.48.3 was better)"

[su_v (suv-lp)]

> now the parameters for all type of light source(distant,point,spot) are visible at once.

Not reproduced with Inkscape 0.48.4 on OS X 10.7.4,
reproduced with Inkscape 0.48+devel r12006

Each time e.g. the user switches between different filter primitives of the current filter, and reselects one of the employed lighting filters, all parameters instead of only those relevant to the chosen light source are displayed in the filter editor dialog.

Based on archived builds, this regression seems to have started with r10957 or 10958 (not reproduced with r10956, reproduced with r10958):
- Revision 10957: "Lots of gtkmm deprecation fixes"
  <http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/10957>
- Revision 10958: "GSEAL fixes"
  <http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/10958>

[su_v (suv-lp)]

@Alex - maybe you could take a closer look what is happening here?

[su_v (suv-lp)]

Also reproduced with trunk r12006 on Ubuntu 12.10 (64bit, VM).

[jazzynico (jazzynico)]

> the parameters for all type of light source(distant,point,spot) are visible at once.

Tested again with revision 13220 on Crunchbang and Windows XP.
Selecting a light source in the list now shows its set of parameters, and not everything as in the screenshot from comment #2. But unfortunately, all the parameters are still visible when no light source is selected.