pick a better filter editor icon

Bug #1092313 reported by insaner on 2012-12-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Wishlist
insaner

Bug Description

the current filter editor icon is the same as the "new document" icon.. can we choose a better one? something sort of like this is pretty standard:

http://turbomilk.com/img/10mis-filter.png

this is related to tidying up the interface

i still havent figured out how to change icons in the inkscape code, so if someone else can do this, (or at least point out to me how to do this, so i can do it myself quickly) that would be great. thanks

su_v (suv-lp) on 2012-12-20
tags: added: filters-svg
removed: icons interface
su_v (suv-lp) wrote :

Can you provide the icon in SVG format (size 16x16 px) that matches the style of the current icon set [1]? It then needs to be added to Inkscape's icons.svg file (with the correct ID), before being referenced in the code (AFAIU, for this dialog, adding it to the definition of the verb is sufficient):
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/view/head:/src/verbs.cpp#L2811>

[1] The current icons file in your local branch is in 'share/icons/icons.svg'

Note: if you plan to edit and resave the current 'icons.svg' file (e.g. for a diff), please use specific settings in Inkscape (to avoid adding unwanted changes to the file under version control), and try e.g. to reuse existing gradients if possible: <http://wiki.inkscape.org/wiki/index.php/Icons#Single_SVG_File>. Else attach an SVG file containing only the new icon.

su_v (suv-lp) on 2012-12-20
Changed in inkscape:
importance: Undecided → Wishlist
status: New → Triaged
insaner (insaner) wrote :

ok, i couldnt really find a better way to create this patch after many attempts.. i will be including a separate svg with the icon (a bit shrunk to 16x16) in any case, in case you want to reconstruct it a nicer/better way

insaner (insaner) wrote :

the file definition so it actually gets picked up by inkscape.. you might have to do some trickery, "make install" didnt copy over the new icon.svg file for me, for some strange reason

insaner (insaner) wrote :

and here is the svg file with just the icon

Changed in inkscape:
assignee: nobody → insaner (insaner)
status: Triaged → In Progress
insaner (insaner) wrote :

this is a smaller patch with the icon design reusing gradients where it was possible. please review and let me know if it all works properly

and while you are at it, please comment on Bug #1113302 too..

su_v (suv-lp) wrote :

Patch tested ok on OS X 10.7.4 with Inkscape 0.48+devel r12104 (GTK+/Quartz 2.24.14, gtk theme: Adwaita GTK2 (Gnome 3.6), icon theme: hicolor): the new icon is used for the menu item and the dialog title bar, as well as for the buttons of the switcher and the minimized state.

jazzynico (jazzynico) wrote :

Tested successfully on Windows XP, Inkscape trunk revision 12106.
But why does the patch add two almost identical icons to the file?
The icon with id=dialog-filters (looks correct) is hidden under the one with id=g3989 (apparently not used at all).

insaner (insaner) wrote :

hmm.. not sure how that happened. good catch, thanks!

heres another one without the duplicate

insaner (insaner) wrote :

size adjusted, pixel grid-aligned and rect-groupped..

jazzynico (jazzynico) wrote :

Tested successfully on Windows XP, Inkscape trunk revision 12119.

The patch also modifies other objects (#fill_conical, #fill_mesh and #mesh-gradient). Is it done on purpose?
That apart, it's ok for me to commit the new icon.

insaner (insaner) wrote :

hmm.. well it wasn't something I did myself, so I'm not sure why it happened, but from what I could tell, it seems to be that it's just adding id's to their paths.. I don't really want to edit the diff by hand, so if it's ok with you guys I can just check it in as is.. what do you think?

insaner (insaner) wrote :

here it is.. no id's.. let me know and i will check in..

insaner (insaner) wrote :

i will be checking this in hopefully by friday. let me know if there are any issues

insaner (insaner) on 2013-03-22
Changed in inkscape:
status: In Progress → Fix Committed
jazzynico (jazzynico) on 2013-03-22
Changed in inkscape:
milestone: none → 0.49
Bryce Harrington (bryce) on 2015-02-21
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments